[WIP] Round power values for SA power distribution reports#1194
Closed
vmouradian wants to merge 1 commit intomainfrom
Closed
[WIP] Round power values for SA power distribution reports#1194vmouradian wants to merge 1 commit intomainfrom
vmouradian wants to merge 1 commit intomainfrom
Conversation
Signed-off-by: vmouradian <valentin.mouradian@artelys.com>
vmouradian
changed the title
|
geofjamg
requested changes
Feb 24, 2025
| .withUntypedValue(MISMATCH, mismatch) | ||
| .withUntypedValue("distributed", mismatch - remaining) | ||
| .withUntypedValue("remaining", remaining) | ||
| .withUntypedValue(MISMATCH, String.format(Locale.UK, "%.2f", mismatch)) |
Member
There was a problem hiding this comment.
This is not the right way to solve this issue because you lost the value type (double -> String) in the report model just for testing purpose.
This PR will provide a better way to handle this.
Member
|
May will close it ? |
geofjamg
changed the title
Member
|
closing, will be fixed by #1187 instead |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Reports for active power distribution in SA can have a 0.0 value or a very small one (like 1.654765476E-15) depending on the runs which cause uncertainty for unit tests results.
In this PR, suggestion is to format them to "%.2f"