Remove VoltageMonitoring outerloop when not needed by network #1320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
SylvestreSakti
approved these changes
Dec 22, 2025
jeandemanged
approved these changes
Jan 2, 2026
github-project-automation
bot
moved this from Waiting for review
to Approved
in Release 03/2026
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
The VoltageMonitoring outerloop needs to be active by default to simulate correctly StaticVarCompensators using a standBy automation.
However, this outerloop is not needed when no such device is on a network.
This PR takes advantage of the new OuterLoop.isNeeded protocol to remove this outerloop when the network does not contain such device. In this case, the outerloop does not appear in the reports.
What is the current behavior?
VoltageMonitoring outerloop appears in all reports even if not needed by the network.
What is the new behavior (if this is a feature change)?
VoltageMonitoring outerloop is active by default, but appears on reports only if the Network has devices that require this outerloop.
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information:
Tests that compare reports may need to be modified.