feat(docs): add CompatibilityTestBot and document webhook deduplication differences#10
Merged
neil-pozetroninc merged 1 commit intomainfrom Oct 24, 2025
Merged
Conversation
…on differences Adds CompatibilityTestBot example that disables idempotency middleware to match Probot (Node.js) behavior, which does not automatically deduplicate webhooks by delivery ID. This behavioral difference was previously undocumented in the migration guide and comparison materials. Documentation updates: - Add comprehensive Section 7 to Probot-to-ProbotSharp-Guide.md explaining the deduplication difference with code examples for both frameworks - Update README.md comparison table to highlight webhook deduplication difference - Add Probot comparison notes to Architecture.md, AdapterConfiguration.md, ConfigurationBestPractices.md, and Operations.md - Document when to enable/disable idempotency middleware CompatibilityTestBot features: - HTTP-based integration testing against real server process - TestEventTracker to verify webhook delivery processing - Tracks all deliveries including duplicates (Probot-compatible behavior) - Demonstrates proper ASP.NET Core Minimal API patterns - Comprehensive README with troubleshooting and testing guidance This ensures developers migrating from Probot understand the idempotency difference and can choose appropriate behavior for their use case. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds CompatibilityTestBot and comprehensive documentation explaining the critical behavioral difference between Probot (Node.js) and ProbotSharp regarding webhook deduplication.
Key Changes:
Problem Statement
Probot (Node.js) does NOT automatically deduplicate webhooks by delivery ID. The application is responsible for tracking processed delivery IDs and implementing deduplication logic.
ProbotSharp takes a more opinionated approach with built-in deduplication via
UseIdempotency()middleware (enabled by default in all examples).This critical behavioral difference was previously undocumented in:
Solution
1. CompatibilityTestBot Example (6 new files, 940 lines)
examples/CompatibilityTestBot/- Complete test applicationUseIdempotency()to match Probot behaviorFeatures:
2. Documentation Updates (154 lines added across 6 files)
Probot-to-ProbotSharp-Guide.md:
README.md:
Architecture.md:
AdapterConfiguration.md:
ConfigurationBestPractices.md:
Operations.md:
Impact
For Developers:
For Documentation:
Testing
Files Changed
New Files (6):
Modified Files (6):
Total: 12 files changed, 1,094 insertions(+)
Related Issues
This addresses the documentation gap identified regarding webhook deduplication behavioral differences between Probot and ProbotSharp.
Ready for Review ✅