fix: Standardize webhook secret configuration across documentation#9
Merged
neil-pozetroninc merged 1 commit intomainfrom Oct 23, 2025
Merged
Conversation
Fixes critical configuration mismatch where documentation instructed users to set PROBOTSHARP_GITHUB_WEBHOOKSECRET but code expects PROBOTSHARP_WEBHOOK_SECRET, causing webhook validation failures. Changes: - Updated all .env.example files to use PROBOTSHARP_WEBHOOK_SECRET - Fixed docker-compose.yml environment variable mapping - Updated documentation in Operations.md and README files - Standardized configuration pattern across entire codebase This is a documentation-only change; the code already supports the correct configuration through its fallback chain.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PROBOTSHARP_GITHUB_WEBHOOKSECRETbut code expectsPROBOTSHARP_WEBHOOK_SECRETChanges
.env.examplefiles to usePROBOTSHARP_WEBHOOK_SECRETdocker-compose.ymlenvironment variable mappingOperations.mdand README filesImpact
This fixes a critical issue where users following the documentation would encounter HTTP 500 errors with "Webhook secret is not configured" when GitHub sends webhook events, even though they had configured the secret according to the documentation.
Test Plan
.env.example.env.examplefiles.env.examplefilesPROBOTSHARP_WEBHOOK_SECRETin fallback chainBreaking Changes
None - this is a documentation-only fix that aligns documentation with existing code behavior.