JSONB filter values that are not dates are coerced into NaN #1060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
maybe we can add few tests for that? |
Collaborator
Author
|
I'll add a couple of tests! |
|
Any eta when it will be merged? |
Collaborator
Author
|
@xShazzy the only thing lacking is tests, it would help a lot if perhaps you'd have time to contribute those? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The condition
!Number.isNaN(value)was always true, causing all JSONB column queries to be coerced intoNumber(value), which resulted inNaN.Solution
Updated the check to
!Number.isNaN(Number(value))to ensure that the numeric conversion is properly validated before use.Additionally, I also added the
jsoncolumn type as a valid JSON column type. Bothjsonbandjsonseem to work just fine for JSON operations in TypeORM :)