feat: allow string as schema for paginatedswaggerdocs#1108
Open
dariozachow wants to merge 4 commits intoppetzold:masterfrom
Open
feat: allow string as schema for paginatedswaggerdocs#1108dariozachow wants to merge 4 commits intoppetzold:masterfrom
dariozachow wants to merge 4 commits intoppetzold:masterfrom
Conversation
Signed-off-by: Dario Zachow <dario.zachow@deutschebahn.com>
Owner
|
@vsamofal PTAL when you have a moment 🙏 |
Collaborator
|
@dariozachow as far as I understand you are trying to avoid a dto being added as an extra model, and just allow to pass a name of it in schema. it's not a breaking change so we should be ok, but can you write tests with at least 1 success and 1 failed case (when schema won't be found) |
Author
|
don't think its that easy to write a failed case because the handling of the schema is done by the swagger lib. It just returns the string with the reference to the schema. So thats logic provided by the swagger lib. I can add a test though which takes a string |
Signed-off-by: Dario Zachow <dario.zachow@deutschebahn.com>
Signed-off-by: Dario Zachow <dario.zachow@deutschebahn.com>
Author
|
@vsamofal can you take a look again? |
Author
|
@ppetzold can you take a look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1101