Skip to content

feat: allow string as schema for paginatedswaggerdocs#1108

Open
dariozachow wants to merge 4 commits intoppetzold:masterfrom
dariozachow:master
Open

feat: allow string as schema for paginatedswaggerdocs#1108
dariozachow wants to merge 4 commits intoppetzold:masterfrom
dariozachow:master

Conversation

@dariozachow
Copy link
Copy Markdown

fixes #1101

Signed-off-by: Dario Zachow <dario.zachow@deutschebahn.com>
@ppetzold
Copy link
Copy Markdown
Owner

ppetzold commented Oct 9, 2025

@vsamofal PTAL when you have a moment 🙏

@vsamofal
Copy link
Copy Markdown
Collaborator

vsamofal commented Oct 12, 2025

@dariozachow as far as I understand you are trying to avoid a dto being added as an extra model, and just allow to pass a name of it in schema.

it's not a breaking change so we should be ok, but can you write tests with at least 1 success and 1 failed case (when schema won't be found)

@dariozachow
Copy link
Copy Markdown
Author

don't think its that easy to write a failed case because the handling of the schema is done by the swagger lib. It just returns the string with the reference to the schema. So thats logic provided by the swagger lib. I can add a test though which takes a string

Signed-off-by: Dario Zachow <dario.zachow@deutschebahn.com>
Signed-off-by: Dario Zachow <dario.zachow@deutschebahn.com>
@dariozachow
Copy link
Copy Markdown
Author

@vsamofal can you take a look again?

@dariozachow
Copy link
Copy Markdown
Author

@ppetzold can you take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support custom swagger components in PaginatedSwaggerDocs

3 participants