New semantics and query construction for to-many relationships #1112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR begins addressing some of the issues with undefined behavior in to-many relationship filtering (closes #1110), and adds support for several new use cases. It also serves as an experiment to see if
EXISTSbased querying is a viable replacement for the problematic overlap that filtering by relationships with JOINs and WHERE poses right now with the unwanted filtering of the returned related entities (closes #1105). I think if this works out well we should create a benchmark and see what happens to performance if we introduce the same EXISTS-based queries for all to-one relationships as well.