-
Notifications
You must be signed in to change notification settings - Fork 119
feat: add support for getRawMany() and row count as it is #975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: add support for getRawMany() and row count as it is #975
Conversation
ppetzold
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks solid at first sight. Could you add new config params description to README?
Hi, And I have some concerns
|
|
Hi! I'd like to weigh in here on point 3:
|
|
Are there any updates here? |
|
Hello @ppetzold Thank you in advance, |
|
Are there any updates here? |
|
Hi @ppetzold 👋 It looks like the original author hasn’t responded for a while, and the remaining work on this PR seems to be mainly the README/documentation updates. I’m interested in continuing this work. Would it be okay if I take this over? |
|
@fpnuseis yep sure, you are welcome to do so |
Hi,
In this PR, I try to solve two following issues:
getManyAndCount()typeorm/typeorm#5127 , Bug - .groupBy is empty on count query, resulting in wrong count when .groupBy is used typeorm/typeorm#7454I totally open for any feedback, and I do really need @ppetzold guidance to improve my changes in this PR.
Thank You