Skip to content

Fix libflac build by using windows-2022 for x86#252

Merged
smoogipoo merged 1 commit intoppy:masterfrom
Susko3:fix-win-x86
Sep 19, 2025
Merged

Fix libflac build by using windows-2022 for x86#252
smoogipoo merged 1 commit intoppy:masterfrom
Susko3:fix-win-x86

Conversation

@Susko3
Copy link
Copy Markdown
Member

@Susko3 Susko3 commented Sep 19, 2025

windows-latest runners updated from windows server 2022 to windows server 2025 and this broke our win-x86 build. I don't really want to investigate further, so I've just rolled-back the winx-86 build to windows server 2022.

Failing run on master: https://github.com/Susko3/SDL3-CS/actions/runs/17860376465/job/50789284984
Working run with this PR's changes: https://github.com/Susko3/SDL3-CS/actions/runs/17860427227/job/50789477421

Build FAILED.

"D:\a\SDL3-CS\SDL3-CS\External\SDL_mixer\build\ALL_BUILD.vcxproj" (default target) (1) ->
"D:\a\SDL3-CS\SDL3-CS\External\SDL_mixer\build\SDL3_mixer-shared.vcxproj" (default target) (3) ->
"D:\a\SDL3-CS\SDL3-CS\External\SDL_mixer\build\external\flac-build\src\libFLAC\FLAC.vcxproj" (default target) (4) ->
"D:\a\SDL3-CS\SDL3-CS\External\SDL_mixer\build\external\flac-build\src\libFLAC\ia32\FLAC-asm.vcxproj" (default target) (5) ->
(_NASM target) -> 
  C:\Program Files\CMake\share\cmake-3.31\Templates\MSBuild\nasm.targets(33,5): error MSB3721: The command ""C:/Strawberry/c/bin/nasm.exe" -o "FLAC-asm.dir\Release\cpu_asm.obj" -fwin32 -I"D:\a\SDL3-CS\SDL3-CS\External\SDL_mixer\external\flac\src\libFLAC\ia32\\" -I"D:\a\SDL3-CS\SDL3-CS\External\SDL_mixer\external\flac\include\\" -I"D:\a\SDL3-CS\SDL3-CS\External\SDL_mixer\build\external\flac-build\\" -I"D:\a\SDL3-CS\SDL3-CS\External\SDL_mixer\external\flac\src\libFLAC\ia32\\" -D"CMAKE_INTDIR="Release"" -dOBJ_FORMAT_win32 /wd4267 /wd4996 "D:\a\SDL3-CS\SDL3-CS\External\SDL_mixer\external\flac\src\libFLAC\ia32\cpu_asm.nasm"" exited with code 1. [D:\a\SDL3-CS\SDL3-CS\External\SDL_mixer\build\external\flac-build\src\libFLAC\ia32\FLAC-asm.vcxproj]

The last line is (with word-wrap):
C:\Program Files\CMake\share\cmake-3.31\Templates\MSBuild\nasm.targets(33,5): error MSB3721: The command ""C:/Strawberry/c/bin/nasm.exe" -o "FLAC-asm.dir\Release\cpu_asm.obj" -fwin32 -I"D:\a\SDL3-CS\SDL3-CS\External\SDL_mixer\external\flac\src\libFLAC\ia32\\" -I"D:\a\SDL3-CS\SDL3-CS\External\SDL_mixer\external\flac\include\\" -I"D:\a\SDL3-CS\SDL3-CS\External\SDL_mixer\build\external\flac-build\\" -I"D:\a\SDL3-CS\SDL3-CS\External\SDL_mixer\external\flac\src\libFLAC\ia32\\" -D"CMAKE_INTDIR="Release"" -dOBJ_FORMAT_win32 /wd4267 /wd4996 "D:\a\SDL3-CS\SDL3-CS\External\SDL_mixer\external\flac\src\libFLAC\ia32\cpu_asm.nasm"" exited with code 1. [D:\a\SDL3-CS\SDL3-CS\External\SDL_mixer\build\external\flac-build\src\libFLAC\ia32\FLAC-asm.vcxproj]

@smoogipoo smoogipoo merged commit dbbd262 into ppy:master Sep 19, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants