Add workaround for pen clicks not working on Android#6703
Merged
smoogipoo merged 1 commit intoppy:masterfrom Jan 29, 2026
Merged
Add workaround for pen clicks not working on Android#6703smoogipoo merged 1 commit intoppy:masterfrom
smoogipoo merged 1 commit intoppy:masterfrom
Conversation
hwsmm
approved these changes
Jan 27, 2026
Contributor
hwsmm
left a comment
There was a problem hiding this comment.
Just a remark: if (penProximityWorkaround) in tryGetPenDevice is always reached because current Android SDL3 sends a motion event before a proximity-in event (which is a bug).
Other than that, I confirmed that this works fine on my tablet, and ticks most boxes in the OP. I'm not sure about the condition of 'SDL_GetPenDeviceType() in tryGetPenDeviceType() never fails', though..
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As reported on the osu! forum:
Closes ppy/osu#36480
From users logs I've gathered, pens on android currently report they've left proximity right before a click/touch. This is unexpected behaviour from both SDL and Android, as a pen should remain in proximity while it's touching the screen. #6695 made pen handling stricter and this caused the regression.
There are efforts to fix this on SDL's side, but progress has died down as it involves implementing a hack instead of trying to figure out why the Android part is not up to spec.
Instead, let's fix this locally in osu!framework by fetching the pen device type on all event types. The workaround is only applied on Android, as that's the platform with user reports (x11/xinput2 should also be broken, but affected users can use SDL2 or Wayland).
Testing
I don't currently have a device to test with.
On Android:
SDL_GetPenDeviceType()intryGetPenDeviceType()never fails!penProximityWorkaroundcheck is removed fromhandlePenProximityEvent()