Skip to content

Add arbitrary approved_date for test runs #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bdach merged 3 commits into from
Dec 29, 2025
Merged

Add arbitrary approved_date for test runs #351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2f4d7b1
Add arbitrary `approved_date` for test runs
peppy Dec 26, 2025
f3f1013
Remove taiko "swap" mod from disallowed list
peppy Dec 26, 2025
7775fd9
Fix missing attribs
peppy Dec 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion osu.Server.Queues.ScoreStatisticsProcessor.Tests/DatabaseTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ protected void IgnoreProcessorExceptions()
protected Beatmap AddBeatmap(Action<Beatmap>? beatmapSetup = null, Action<BeatmapSet>? beatmapSetSetup = null)
{
var beatmap = new Beatmap { approved = BeatmapOnlineStatus.Ranked };
var beatmapSet = new BeatmapSet { approved = BeatmapOnlineStatus.Ranked };
var beatmapSet = new BeatmapSet { approved = BeatmapOnlineStatus.Ranked, approved_date = DateTimeOffset.Now.AddHours(-1) };

beatmapSetup?.Invoke(beatmap);
beatmapSetSetup?.Invoke(beatmapSet);
Expand Down
3 changes: 3 additions & 0 deletions osu.Server.Queues.ScoreStatisticsProcessor.Tests/GearShiftTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// See the LICENCE file in the repository root for full licence text.

using osu.Game.Online.API;
using osu.Game.Rulesets.Osu.Difficulty;
using osu.Game.Rulesets.Osu.Mods;
using osu.Server.Queues.ScoreStatisticsProcessor.Models;
using Xunit;
Expand All @@ -16,6 +17,8 @@ public GearShiftTest()
{
AddMedal(339);
beatmap = AddBeatmap();

AddBeatmapAttributes<OsuDifficultyAttributes>(beatmap.beatmap_id, mods: [new OsuModDoubleTime()]);
}

[Fact]
Expand Down
1 change: 0 additions & 1 deletion osu.Server.Queues.ScoreStatisticsProcessor.Tests/PerformanceProcessorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,6 @@ public void ModsThatDoNotGivePpAreDisallowed()
new OsuModDifficultyAdjust(),
// Taiko
new TaikoModRandom(),
new TaikoModSwap(),
// Catch
new CatchModMirror(),
new CatchModFloatingFruits(),
Expand Down