Skip to content

Fix bogus default for maximum playlist duration with supporter#12879

Merged
nanaya merged 3 commits intoppy:masterfrom
bdach:MATH
Mar 27, 2026
Merged

Fix bogus default for maximum playlist duration with supporter#12879
nanaya merged 3 commits intoppy:masterfrom
bdach:MATH

Conversation

@bdach
Copy link
Copy Markdown
Contributor

@bdach bdach commented Mar 26, 2026

The inline comment just above it links to a line in client that ballparks 1 month = 31 days. The maximum in client is 3 months. 31 * 3 = 93 and not 63.

As reported in https://discord.com/channels/188630481301012481/1097318920991559880/1486690459203141783

The inline comment just above it links to a line in client that
ballparks 1 month = 31 days. 31 * 3 = 93 and not 63.

As reported in https://discord.com/channels/188630481301012481/1097318920991559880/1486690459203141783
@bdach bdach self-assigned this Mar 26, 2026
@bdach bdach moved this from Inbox to Pending Review in osu! team task tracker Mar 26, 2026
Copy link
Copy Markdown
Collaborator

@nanaya nanaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the value in .env.example also need updating

@nanaya nanaya enabled auto-merge March 27, 2026 08:44
@nanaya nanaya merged commit 06819ed into ppy:master Mar 27, 2026
3 checks passed
@github-project-automation github-project-automation bot moved this from Pending Review to Done in osu! team task tracker Mar 27, 2026
@bdach bdach deleted the MATH branch March 27, 2026 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants