Introduce interfaces for difficulty & performance attributes#30707
Closed
minisbett wants to merge 4 commits intoppy:masterfrom
Closed
Introduce interfaces for difficulty & performance attributes#30707minisbett wants to merge 4 commits intoppy:masterfrom
minisbett wants to merge 4 commits intoppy:masterfrom
Conversation
Contributor
Author
|
I realized I forgot something, will get back to this tomorrow. |
Contributor
Author
|
We could change the difficulty calculator to accept the interface instead, so the structs I'm implementing in osu-native can be directly passed into the calculator. Thoughts? Edit: Actually this does not work. Due to the nature of what I need in osu-native (and what smoogi said), I decided to not include the mods property in the interface. But since the difficulty calculator needs it it will not be satisfied. The main issue I'm having in osu-native is that I cannot deal with a Mod[] property. If there'd be any way around it, the attributes could as well be made structs in Lazer directly. |
Contributor
Author
|
Closed in favor of #30727 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows 3rd-parties using Lazer's code base to contract the attributes to ensure they always match.
This was suggested by smoogi to assist with the development of osu-native.