Fix replay/spectator scroll text not toggling with Ctrl+H

[peppy]

Intended to add toggle but forgot.

This also fixes #37012 via a convoluted refactor of a lot of stuff. The basic overview is:

• Moved all replay overlay concerns out of HUDOverlay. We can display this above everything confidently (i think).
• Split out ReplayOverlay and ReplaySettingsOverlay so the base class can handle the visibility, hotkeys and everything that should be shared with all replay overlay components going forward. Ctrl+H is supposed to hide any of these kinds of details, and I'm sure we'll add more in the future.
• Reorganised some things in Player so the new structure would work. Mainly the overlays which add a black layer during fade out.

[bdach]

• Replay controls are still fully interactable even when they're toggled off.

Screen.Recording.2026-03-18.at.10.34.15.mov

• In multiplayer spectator completely hiding the new replay overlay means that there is no way to know which player is which anymore.

[bdach]

FYI since I saw you refer to this as already merged in changelog comments it's not already merged due to review objections above. Also needs merge conflict resolution now. And possibly once more with #37164.

[peppy]

🤦

[bdach]

This is still an issue, as it will hide not only the settings overlay but the scrolling text too, which is important because that's the only visual indication as to who's who on the screen.

diff --git a/osu.Game/Screens/Play/SpectatorPlayer.cs b/osu.Game/Screens/Play/SpectatorPlayer.cs
index 910a4aef65..ab01dd9118 100644
--- a/osu.Game/Screens/Play/SpectatorPlayer.cs
+++ b/osu.Game/Screens/Play/SpectatorPlayer.cs
@@ -35,26 +35,31 @@ protected SpectatorPlayer(Score score, PlayerConfiguration? configuration = null
         [BackgroundDependencyLoader]
         private void load()
         {
+            // TODO: This should be customised for `MultiplayerSpectatorPlayer` to be static and only show the player name.
+            // Or maybe we should completely redesign this to show the user avatar and other things if that happens.
+            OsuTextFlowContainer message = new OsuTextFlowContainer(cp => cp.Font = OsuFont.Style.Body) { AutoSizeAxes = Axes.Both };
+            message.AddText("Watching ");
+            message.AddText(Score.ScoreInfo.User.Username, s => s.Font = s.Font.With(weight: FontWeight.SemiBold));
+            message.AddText(" play ");
+            message.AddText(Beatmap.Value.BeatmapInfo.GetDisplayTitleRomanisable(), s => s.Font = s.Font.With(weight: FontWeight.SemiBold));
+            message.AddText(" live", s => s.Font = s.Font.With(weight: FontWeight.Bold));
+            var scrollingMessage = new ScrollingMessage(message)
+            {
+                Y = 96,
+                Anchor = Anchor.TopCentre,
+                Origin = Anchor.TopCentre,
+            };
+
             if (ShowSettingsOverlay)
             {
                 var replayOverlay = new ReplayOverlay();
                 GameplayClockContainer.Add(replayOverlay);
 
-                // TODO: This should be customised for `MultiplayerSpectatorPlayer` to be static and only show the player name.
-                // Or maybe we should completely redesign this to show the user avatar and other things if that happens.
-                OsuTextFlowContainer message = new OsuTextFlowContainer(cp => cp.Font = OsuFont.Style.Body) { AutoSizeAxes = Axes.Both };
-                message.AddText("Watching ");
-                message.AddText(Score.ScoreInfo.User.Username, s => s.Font = s.Font.With(weight: FontWeight.SemiBold));
-                message.AddText(" play ");
-                message.AddText(Beatmap.Value.BeatmapInfo.GetDisplayTitleRomanisable(), s => s.Font = s.Font.With(weight: FontWeight.SemiBold));
-                message.AddText(" live", s => s.Font = s.Font.With(weight: FontWeight.Bold));
-
-                replayOverlay.SetMessage(new ScrollingMessage(message)
-                {
-                    Y = 96,
-                    Anchor = Anchor.TopCentre,
-                    Origin = Anchor.TopCentre,
-                });
+                replayOverlay.SetMessage(scrollingMessage);
+            }
+            else
+            {
+                GameplayClockContainer.Add(scrollingMessage);
             }
         }
 

is a possible alternative.

[bdach]

Or it may be easier to incorporate #37164 into this PR since the two will conflict almost instantaneously. This one is removing the virtual method that one is trying to override.

[peppy]

Or I guess I merge this and then #37164 immediately after

Yeah, I'd probably be changing that PR to make the text there always visible, not part of this overlay, or something. Will revisit once this is merged, or feel free to do so for me 😅

Can apply your patch above if you want to keep master in a good state.

[bdach]

I'll just merge as is since it's not going to get lost in merge conflict resolution anyway.