Extract common components from BeatmapLeaderboardScore#37079
Open
LiquidPL wants to merge 5 commits intoppy:masterfrom
Open
Extract common components from BeatmapLeaderboardScore#37079LiquidPL wants to merge 5 commits intoppy:masterfrom
BeatmapLeaderboardScore#37079LiquidPL wants to merge 5 commits intoppy:masterfrom
Conversation
This commit extracts the rank display component, along with its highlight logic to a separate component, to be reused on the playlists score component.
Specifically user (username, avatar, flag, team), rank (in the overlay showing above the avatar when in compact mode) and date.
peppy
reviewed
Mar 25, 2026
|
|
||
| namespace osu.Game.Online.Leaderboards | ||
| { | ||
| public partial class LeaderboardCommonDisplay : Container |
Member
There was a problem hiding this comment.
Dunno about naming here.
How about LeaderboardScoreUserInfo?
All these components may work better as partial classes inside LeaderboardScore given how they are all just pieces of that component (i think?)
See something like BeatmapTitleWedge and adjacent files as an example.
Contributor
Author
There was a problem hiding this comment.
Wouldn't it look awkward if I then reuse them on a potential PlaylistsLeaderboardScore and it'll have a bunch of references to BeatmapLeaderboardScore.<something>? I don't think it's that big of a deal but it would be at least a little eyebrow raising.
But then on the other hand I am already pulling in constants from it in some places so I guess it's fine?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specifically user (username, avatar, flag, team), rank (in the overlay
showing above the avatar when in compact mode) and date.
Depends on #37064.