Add invert selection keybinding to editor#37118
Open
dinkelspiel wants to merge 2 commits intoppy:masterfrom
Open
Add invert selection keybinding to editor#37118dinkelspiel wants to merge 2 commits intoppy:masterfrom
dinkelspiel wants to merge 2 commits intoppy:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the ability to invert the current hit object selection in the editor.
Why
Ctrl + ICtrl + Imatches the selection inversion shortcut used by programs like GIMP and Paint.NET, so it should feel familiar to users instead of introducing a new convention.Why not
Ctrl + Shift + IPhotoshop and Krita use
Ctrl + Shift + Ifor selection inversion, but in PhotoshopCtrl + Iis already used for the image inversion filter. Since osu! has no equivalent "invert image" action that would use this shortcut,Ctrl + Iis the more appropriate choice here.