Simplify and consolidate distance variables used throughout aim evaluators without changing values#37150
Open
Finadoggie wants to merge 10 commits intoppy:pp-devfrom
Open
Simplify and consolidate distance variables used throughout aim evaluators without changing values#37150Finadoggie wants to merge 10 commits intoppy:pp-devfrom
Finadoggie wants to merge 10 commits intoppy:pp-devfrom
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR simplifies a lot of the complication regarding distance values by renaming variables and adding a
GetDistance()function to be used when getting distance normally.It does not change any values. The change in structure makes other problems more apparent, which can be addressed in future PRs.
Part 1 of #37124