sign stack usage: Re-use y/h buffer #818
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkannwischer
force-pushed
the
sign-stack-yh-3
branch
3 times, most recently
from
c103d48 to
be25453
Compare
hanno-becker
requested changes
Dec 30, 2025
Contributor
hanno-becker
left a comment
hanno-becker
left a comment
There was a problem hiding this comment.
I believe that a separate config option is the right approach for now. We will hopefully be able to shift some things in the default config once we overcome CBMC issues, but other aspects such as the ad-hoc matrix generation will always remain a trade-off between performance and RAM usage.
Only some smaller comments regarding documentation and the Makefile.
Contributor
hanno-becker
left a comment
hanno-becker
left a comment
There was a problem hiding this comment.
I forgot: Please clearly state in the relevant places that MLK_CONFIG_REDUCE_RAM is not covered by CBMC proof.
This commit is the second commit working towards bringing down the memory consumption of signature_internal. It combines the y and h buffer as those lifetime does not overlap. We work around diffblue/cbmc#8813 by using a struct by default and only using a union if MLD_CONFIG_REDUCE_RAM is used. Signed-off-by: Matthias J. Kannwischer <[email protected]>
Signed-off-by: Matthias J. Kannwischer <[email protected]>
Signed-off-by: Matthias J. Kannwischer <[email protected]>
mkannwischer
force-pushed
the
sign-stack-yh-3
branch
from
be25453 to
3e40995
Compare
hanno-becker
approved these changes
Dec 30, 2025
Contributor
hanno-becker
left a comment
hanno-becker
left a comment
There was a problem hiding this comment.
Thanks @mkannwischer !
This was referenced Dec 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to