testing: do not generate custom build for rng failure test #864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a follow up to e15b34f, we modify the rng failure test so that it does not generate a new build. To achieve this we do the following: * Modify components.mk so that it does not generate new objects for the rng test. Simply reuse the MLDSAxx_OBJS * Updated test function names to use standard crypto_sign_* API instead of mld_* aliases as the mld_* namespace is no longer available as we are now using the default build with MLD_DEFAULT_NAMESPACE_PREFIX. Those functions which are not exposed in this way by default are wrapped with MLD_API_NAMESPACE. * Removed redundant build rules from components.mk and rules.mk Signed-off-by: Andreas Hatziiliou <[email protected]>
| static uint32_t out[8]; | ||
| static int32_t outleft = 0; | ||
|
|
||
| int randombytes_counter __attribute__((weak)) = 0; |
Contributor
There was a problem hiding this comment.
Why do we need to change notrandombytes? I was hoping we just don't link that when we build the RNG failure test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow up to e15b34f, we modify the rng failure test so that it
does not generate a new build. To achieve this we do the following:
the rng test. Simply reuse the MLDSAxx_OBJS
instead of mld_* aliases as the mld_* namespace is no longer available
as we are now using the default build with
MLD_DEFAULT_NAMESPACE_PREFIX. Those functions which are not exposed
in this way by default are wrapped with MLD_API_NAMESPACE.
--wrap linker flag which resolves strong definitions of randombytes to
__real_randombytes and all calls within the test suite to
__wrap_randombytes.
Signed-off-by: Andreas Hatziiliou [email protected]