mldsa_native.h: Add PCT-aware MLD_TOTAL_ALLOC constants #869
+74
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /* check-magic: off */ | ||
| #if defined(MLD_API_LEGACY_CONFIG) || !defined(MLD_CONFIG_REDUCE_RAM) | ||
| #define MLD_TOTAL_ALLOC_44_KEYPAIR 56640 | ||
| #define MLD_TOTAL_ALLOC_44_KEYPAIR_NO_PCT 45248 |
Contributor
There was a problem hiding this comment.
Nit: I would suggest MLD_TOTAL_XXX (no PCT) as the default, and MLD_TOTAL_XXX_PCT for configurations with PCT. The MLK_CONFIG_KEYGEN_PCT is also a positive option that's disabled by default.
Contributor
Author
There was a problem hiding this comment.
hmm, lower in the file MLD_TOTAL_XXX is defined depending on the actual value of MLK_CONFIG_KEYGEN_PCT.
Contributor
There was a problem hiding this comment.
Nevermind, I hadn't yet seen the wrapper below.
Split KEYPAIR allocation constants into _NO_PCT and _PCT variants to accurately reflect memory usage with and without pairwise consistency testing (PCT). MLD_TOTAL_ALLOC_*_KEYPAIR now automatically selects the appropriate value based on MLD_CONFIG_KEYGEN_PCT. For legacy configs, assume PCT is enabled (conservative). Also correct REDUCE_RAM KEYPAIR values which were previously using PCT values unconditionally. The default alloc test config no longer enables PCT; PCT is tested via config-variations. Signed-off-by: Matthias J. Kannwischer <[email protected]>
Add config-variations tests for REDUCE_RAM and REDUCE_RAM + PCT configurations to ensure allocation constants are validated for all four configuration variants. Signed-off-by: Matthias J. Kannwischer <[email protected]>
mkannwischer
force-pushed
the
mld-alloc-pct
branch
from
ac68e65 to
0ca77bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split KEYPAIR allocation constants into _NO_PCT and PCT variants to
accurately reflect memory usage with and without pairwise consistency
testing (PCT). MLD_TOTAL_ALLOC*_KEYPAIR now automatically selects
the appropriate value based on MLD_CONFIG_KEYGEN_PCT.
For legacy configs, assume PCT is enabled (conservative).
Also correct REDUCE_RAM KEYPAIR values which were previously using
PCT values unconditionally.
The default alloc test config no longer enables PCT; PCT is tested
via config-variations.