Port: Allow the public header to work in C++ mode. #882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanno-becker
approved these changes
Jan 15, 2026
Without this, includes of the header must be wrapped in extern "C", which then causes problems if the config header includes headers that expect to be included in C or C++ mode. Signed-off-by: willieyz <[email protected]>
hanno-becker
force-pushed
the
port-allow-public-header
branch
from
9aee133 to
2db4371
Compare
mkannwischer
approved these changes
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: Port: Allow the public header to work in C++ mode #870
This PR ports Allow the public header to work in C++ mode. mlkem-native#1465
to mldsa-native.
This change adds standard C++ compatibility guards to
mldsa/mldsa_native.h, allowing C++ projects to include the header directly without requiring manual extern "C" wrapping (the extern "C" declarations are now defined inside mldsa/mldsa_native.h).