Sign: Set smlen to 0 in case of failure by mkannwischer · Pull Request #959 · pq-code-package/mldsa-native

mkannwischer · 2026-02-10T03:18:33Z

Resolves Inconsistent and possibly confusing mld_sign() API and contracts #974

oqs-bot · 2026-02-10T03:37:02Z

CBMC Results (ML-DSA-44)

Full Results (175 proofs)

Proof	Status	Current	Previous	Change
`TOTAL`	✅	1953s	2055s	-5.0%
`mld_attempt_signature_generation`	✅	231s	221s	+5%
`polyvecl_pointwise_acc_montgomery_c`	✅	196s	208s	-6%
`sign_verify_internal`	✅	179s	254s	-30%
`rej_uniform_native`	✅	143s	144s	-1%
`poly_pointwise_montgomery_c`	✅	134s	143s	-6%
`mld_ct_memcmp`	✅	80s	82s	-2%
`mld_invntt_layer`	✅	50s	50s	+0%
`mld_ntt_layer`	✅	45s	44s	+2%
`keccak_squeezeblocks_x4`	✅	43s	44s	-2%
`poly_invntt_tomont_c`	✅	39s	39s	+0%
`sign_signature_internal`	✅	32s	45s	-29%
`fqmul`	✅	21s	19s	+11%
`rej_uniform`	✅	21s	20s	+5%
`polyt0_unpack`	✅	18s	15s	+20%
`rej_uniform_c`	✅	18s	20s	-10%
`poly_uniform_eta_4x`	✅	16s	19s	-16%
`poly_uniform_4x`	✅	15s	13s	+15%
`polymat_permute_bitrev_to_custom`	✅	15s	16s	-6%
`mld_polyvecl_permute_bitrev_to_custom_native`	✅	14s	14s	+0%
`polyvec_matrix_expand`	✅	14s	16s	-12%
`keccakf1600x4_permute_native`	✅	13s	14s	-7%
`poly_chknorm_c`	✅	13s	12s	+8%
`polyz_unpack_c`	✅	13s	12s	+8%
`mld_compute_t0_t1_tr_from_sk_components`	✅	12s	15s	-20%
`mld_ntt_butterfly_block`	✅	12s	13s	-8%
`polyeta_unpack`	✅	12s	12s	+0%
`keccak_absorb_once_x4`	✅	11s	9s	+22%
`sign_pk_from_sk`	✅	10s	6s	+67%
`keccakf1600_permute_native`	✅	8s	6s	+33%
`mld_compute_pack_z`	✅	8s	6s	+33%
`polyveck_add`	✅	8s	7s	+14%
`polyveck_ntt`	✅	8s	4s	+100%
`polyveck_power2round`	✅	8s	6s	+33%
`polyvec_matrix_expand_serial`	✅	7s	7s	+0%
`polyvec_matrix_pointwise_montgomery`	✅	7s	6s	+17%
`polyveck_decompose`	✅	7s	7s	+0%
`polyveck_reduce`	✅	7s	5s	+40%
`polyvecl_chknorm`	✅	7s	6s	+17%
`rej_eta_native`	✅	7s	4s	+75%
`keccakf1600_permute`	✅	6s	8s	-25%
`mld_check_pct`	✅	6s	6s	+0%
`poly_decompose_c`	✅	6s	5s	+20%
`poly_pointwise_montgomery_native`	✅	6s	3s	+100%
`poly_use_hint_c`	✅	6s	5s	+20%
`polyveck_invntt_tomont`	✅	6s	6s	+0%
`polyveck_pointwise_poly_montgomery`	✅	6s	5s	+20%
`polyveck_sub`	✅	6s	4s	+50%
`sign_open`	✅	6s	6s	+0%
`keccak_absorb`	✅	5s	8s	-38%
`mld_sample_s1_s2`	✅	5s	4s	+25%
`pack_sig_c_h`	✅	5s	4s	+25%
`poly_caddq_c`	✅	5s	3s	+67%
`poly_invntt_tomont_native`	✅	5s	4s	+25%
`poly_power2round`	✅	5s	5s	+0%
`poly_uniform`	✅	5s	5s	+0%
`polyveck_pack_eta`	✅	5s	3s	+67%
`polyveck_shiftl`	✅	5s	5s	+0%
`polyveck_unpack_eta`	✅	5s	4s	+25%
`polyvecl_ntt`	✅	5s	6s	-17%
`polyz_unpack_native`	✅	5s	3s	+67%
`shake128_squeeze`	✅	5s	2s	+150%
`sign_keypair`	✅	5s	2s	+150%
`sign_verify`	✅	5s	3s	+67%
`sign_verify_extmu`	✅	5s	2s	+150%
`sign_verify_pre_hash_shake256`	✅	5s	3s	+67%
`keccakf1600_xor_bytes (big endian)`	✅	4s	2s	+100%
`keccakf1600x4_extract_bytes`	✅	4s	3s	+33%
`make_hint`	✅	4s	3s	+33%
`mld_ct_cmask_nonzero_u32`	✅	4s	2s	+100%
`mld_ct_get_optblocker_i64`	✅	4s	2s	+100%
`mld_ct_get_optblocker_u32`	✅	4s	1s	+300%
`mld_ct_get_optblocker_u8`	✅	4s	1s	+300%
`mld_h`	✅	4s	6s	-33%
`poly_caddq_native_aarch64`	✅	4s	3s	+33%
`poly_chknorm_native`	✅	4s	6s	-33%
`poly_invntt_tomont`	✅	4s	2s	+100%
`poly_ntt_c`	✅	4s	2s	+100%
`polyeta_pack`	✅	4s	3s	+33%
`polyveck_caddq`	✅	4s	8s	-50%
`polyveck_unpack_t0`	✅	4s	4s	+0%
`polyveck_use_hint`	✅	4s	5s	-20%
`polyvecl_pack_eta`	✅	4s	3s	+33%
`polyvecl_pointwise_acc_montgomery_native`	✅	4s	3s	+33%
`polyvecl_uniform_gamma1`	✅	4s	2s	+100%
`polyz_unpack`	✅	4s	5s	-20%
`power2round`	✅	4s	2s	+100%
`rej_eta_c`	✅	4s	4s	+0%
`shake256_finalize`	✅	4s	4s	+0%
`sign`	✅	4s	5s	-20%
`sign_keypair_internal`	✅	4s	4s	+0%
`sign_signature`	✅	4s	6s	-33%
`sign_signature_pre_hash_shake256`	✅	4s	5s	-20%
`sign_verify_pre_hash_internal`	✅	4s	4s	+0%
`unpack_sig`	✅	4s	3s	+33%
`unpack_sk`	✅	4s	4s	+0%
`intt_native_x86_64`	✅	3s	3s	+0%
`keccak_squeeze`	✅	3s	5s	-40%
`mld_keccakf1600_extract_bytes`	✅	3s	6s	-50%
`mld_sample_s1_s2_serial`	✅	3s	3s	+0%
`montgomery_reduce`	✅	3s	2s	+50%
`pack_pk`	✅	3s	3s	+0%
`pack_sig_z`	✅	3s	2s	+50%
`pack_sk`	✅	3s	3s	+0%
`poly_add`	✅	3s	4s	-25%
`poly_caddq`	✅	3s	3s	+0%
`poly_challenge`	✅	3s	3s	+0%
`poly_decompose`	✅	3s	4s	-25%
`poly_ntt`	✅	3s	3s	+0%
`poly_ntt_native`	✅	3s	2s	+50%
`poly_pointwise_montgomery`	✅	3s	2s	+50%
`poly_shiftl`	✅	3s	4s	-25%
`poly_uniform_eta`	✅	3s	5s	-40%
`poly_uniform_gamma1`	✅	3s	4s	-25%
`poly_uniform_gamma1_4x`	✅	3s	4s	-25%
`poly_use_hint`	✅	3s	2s	+50%
`poly_use_hint_native`	✅	3s	3s	+0%
`polyt0_pack`	✅	3s	4s	-25%
`polyt1_pack`	✅	3s	1s	+200%
`polyveck_chknorm`	✅	3s	3s	+0%
`polyveck_make_hint`	✅	3s	4s	-25%
`polyveck_pack_w1`	✅	3s	4s	-25%
`polyvecl_unpack_z`	✅	3s	5s	-40%
`polyz_pack`	✅	3s	2s	+50%
`shake128_finalize`	✅	3s	2s	+50%
`shake128_release`	✅	3s	3s	+0%
`shake128x4_absorb_once`	✅	3s	4s	-25%
`shake128x4_squeezeblocks`	✅	3s	2s	+50%
`shake256`	✅	3s	3s	+0%
`shake256_absorb`	✅	3s	2s	+50%
`sign_signature_extmu`	✅	3s	7s	-57%
`sign_signature_pre_hash_internal`	✅	3s	4s	-25%
`unpack_hints`	✅	3s	5s	-40%
`use_hint`	✅	3s	2s	+50%
`caddq`	✅	2s	3s	-33%
`decompose`	✅	2s	3s	-33%
`fqscale`	✅	2s	1s	+100%
`keccak_finalize`	✅	2s	4s	-50%
`keccak_init`	✅	2s	3s	-33%
`keccakf1600_xor_bytes`	✅	2s	2s	+0%
`keccakf1600x4_permute`	✅	2s	3s	-33%
`keccakf1600x4_xor_bytes`	✅	2s	2s	+0%
`mld_ct_abs_i32`	✅	2s	2s	+0%
`mld_ct_cmask_neg_i32`	✅	2s	2s	+0%
`mld_ct_cmask_nonzero_u8`	✅	2s	4s	-50%
`mld_ct_sel_int32`	✅	2s	4s	-50%
`mld_prepare_domain_separation_prefix`	✅	2s	5s	-60%
`mld_value_barrier_u32`	✅	2s	4s	-50%
`mld_value_barrier_u8`	✅	2s	1s	+100%
`ntt_native_x86_64`	✅	2s	3s	-33%
`poly_caddq_native`	✅	2s	2s	+0%
`poly_chknorm`	✅	2s	4s	-50%
`poly_decompose_native`	✅	2s	3s	-33%
`poly_make_hint`	✅	2s	4s	-50%
`poly_reduce`	✅	2s	4s	-50%
`poly_sub`	✅	2s	3s	-33%
`polyveck_pack_t0`	✅	2s	3s	-33%
`polyvecl_permute_bitrev_to_custom`	✅	2s	2s	+0%
`polyvecl_pointwise_acc_montgomery`	✅	2s	4s	-50%
`polyvecl_unpack_eta`	✅	2s	2s	+0%
`reduce32`	✅	2s	3s	-33%
`rej_eta`	✅	2s	1s	+100%
`shake128_absorb`	✅	2s	1s	+100%
`shake128_init`	✅	2s	2s	+0%
`shake256_init`	✅	2s	3s	-33%
`shake256_release`	✅	2s	3s	-33%
`shake256x4_absorb_once`	✅	2s	4s	-50%
`shake256x4_squeezeblocks`	✅	2s	2s	+0%
`sys_check_capability`	✅	2s	4s	-50%
`unpack_pk`	✅	2s	3s	-33%
`keccakf1600_extract_bytes (big endian)`	✅	1s	3s	-67%
`mld_value_barrier_i64`	✅	1s	4s	-75%
`polyt1_unpack`	✅	1s	4s	-75%
`polyvecl_uniform_gamma1_serial`	✅	1s	3s	-67%
`polyw1_pack`	✅	1s	2s	-50%
`shake256_squeeze`	✅	1s	5s	-80%

oqs-bot · 2026-02-10T03:37:31Z

CBMC Results (ML-DSA-87)

Full Results (175 proofs)

Proof	Status	Current	Previous	Change
`TOTAL`	✅	2454s	2449s	+0.2%
`mld_attempt_signature_generation`	✅	260s	227s	+15%
`sign_verify_internal`	✅	199s	353s	-44%
`polyvecl_pointwise_acc_montgomery_c`	✅	189s	165s	+15%
`polyvec_matrix_expand`	✅	159s	153s	+4%
`poly_pointwise_montgomery_c`	✅	152s	128s	+19%
`rej_uniform_native`	✅	146s	139s	+5%
`mld_invntt_layer`	✅	125s	114s	+10%
`polyvec_matrix_expand_serial`	✅	106s	110s	-4%
`mld_ct_memcmp`	✅	90s	74s	+22%
`sign_signature_internal`	✅	48s	46s	+4%
`mld_ntt_layer`	✅	44s	44s	+0%
`keccak_squeezeblocks_x4`	✅	41s	42s	-2%
`polymat_permute_bitrev_to_custom`	✅	28s	24s	+17%
`mld_compute_t0_t1_tr_from_sk_components`	✅	26s	25s	+4%
`rej_uniform`	✅	22s	21s	+5%
`rej_uniform_c`	✅	20s	16s	+25%
`fqmul`	✅	19s	18s	+6%
`poly_chknorm_c`	✅	18s	17s	+6%
`polyveck_add`	✅	17s	13s	+31%
`poly_uniform_4x`	✅	16s	17s	-6%
`polyt0_unpack`	✅	16s	17s	-6%
`mld_ntt_butterfly_block`	✅	15s	13s	+15%
`poly_uniform_eta_4x`	✅	15s	17s	-12%
`polyveck_power2round`	✅	14s	14s	+0%
`keccakf1600x4_permute_native`	✅	13s	12s	+8%
`polyeta_unpack`	✅	13s	13s	+0%
`polyvec_matrix_pointwise_montgomery`	✅	13s	12s	+8%
`polyvecl_ntt`	✅	11s	11s	+0%
`keccak_absorb_once_x4`	✅	10s	10s	+0%
`keccakf1600_permute_native`	✅	10s	10s	+0%
`polyveck_reduce`	✅	10s	13s	-23%
`polyveck_use_hint`	✅	10s	9s	+11%
`poly_invntt_tomont_c`	✅	9s	9s	+0%
`polyveck_ntt`	✅	9s	8s	+12%
`mld_polyvecl_permute_bitrev_to_custom_native`	✅	8s	8s	+0%
`mld_sample_s1_s2`	✅	8s	6s	+33%
`poly_uniform`	✅	8s	6s	+33%
`polyveck_chknorm`	✅	8s	6s	+33%
`polyveck_pointwise_poly_montgomery`	✅	8s	8s	+0%
`sign_pk_from_sk`	✅	8s	9s	-11%
`sign_verify_extmu`	✅	8s	3s	+167%
`keccakf1600_permute`	✅	7s	7s	+0%
`mld_check_pct`	✅	7s	7s	+0%
`poly_decompose_c`	✅	7s	7s	+0%
`polyveck_caddq`	✅	7s	7s	+0%
`polyveck_decompose`	✅	7s	6s	+17%
`polyveck_invntt_tomont`	✅	7s	10s	-30%
`polyvecl_uniform_gamma1`	✅	7s	4s	+75%
`sign`	✅	7s	7s	+0%
`sign_signature_pre_hash_shake256`	✅	7s	4s	+75%
`keccak_absorb`	✅	6s	7s	-14%
`mld_compute_pack_z`	✅	6s	7s	-14%
`mld_prepare_domain_separation_prefix`	✅	6s	3s	+100%
`pack_sk`	✅	6s	3s	+100%
`poly_ntt_c`	✅	6s	1s	+500%
`polyveck_make_hint`	✅	6s	5s	+20%
`polyveck_shiftl`	✅	6s	6s	+0%
`polyveck_unpack_t0`	✅	6s	6s	+0%
`rej_eta_native`	✅	6s	5s	+20%
`sign_keypair_internal`	✅	6s	6s	+0%
`unpack_hints`	✅	6s	4s	+50%
`mld_h`	✅	5s	2s	+150%
`mld_sample_s1_s2_serial`	✅	5s	6s	-17%
`ntt_native_x86_64`	✅	5s	4s	+25%
`poly_challenge`	✅	5s	5s	+0%
`poly_uniform_gamma1_4x`	✅	5s	6s	-17%
`polyveck_pack_w1`	✅	5s	4s	+25%
`polyveck_sub`	✅	5s	7s	-29%
`polyvecl_chknorm`	✅	5s	4s	+25%
`polyvecl_pack_eta`	✅	5s	3s	+67%
`polyz_unpack`	✅	5s	3s	+67%
`polyz_unpack_c`	✅	5s	5s	+0%
`sign_keypair`	✅	5s	3s	+67%
`sign_signature_pre_hash_internal`	✅	5s	5s	+0%
`unpack_sig`	✅	5s	5s	+0%
`unpack_sk`	✅	5s	6s	-17%
`caddq`	✅	4s	4s	+0%
`decompose`	✅	4s	4s	+0%
`keccakf1600_xor_bytes`	✅	4s	2s	+100%
`keccakf1600x4_permute`	✅	4s	2s	+100%
`keccakf1600x4_xor_bytes`	✅	4s	2s	+100%
`mld_ct_cmask_nonzero_u32`	✅	4s	4s	+0%
`mld_ct_get_optblocker_i64`	✅	4s	3s	+33%
`mld_ct_sel_int32`	✅	4s	2s	+100%
`mld_value_barrier_i64`	✅	4s	3s	+33%
`montgomery_reduce`	✅	4s	3s	+33%
`pack_pk`	✅	4s	4s	+0%
`poly_caddq`	✅	4s	2s	+100%
`poly_caddq_native`	✅	4s	2s	+100%
`poly_caddq_native_aarch64`	✅	4s	3s	+33%
`poly_chknorm`	✅	4s	2s	+100%
`poly_invntt_tomont_native`	✅	4s	2s	+100%
`poly_ntt`	✅	4s	3s	+33%
`poly_ntt_native`	✅	4s	6s	-33%
`poly_sub`	✅	4s	3s	+33%
`poly_uniform_eta`	✅	4s	4s	+0%
`poly_uniform_gamma1`	✅	4s	3s	+33%
`polyt0_pack`	✅	4s	5s	-20%
`polyvecl_permute_bitrev_to_custom`	✅	4s	2s	+100%
`polyvecl_uniform_gamma1_serial`	✅	4s	7s	-43%
`polyz_pack`	✅	4s	2s	+100%
`rej_eta_c`	✅	4s	4s	+0%
`shake128x4_absorb_once`	✅	4s	4s	+0%
`shake256_absorb`	✅	4s	3s	+33%
`shake256_release`	✅	4s	3s	+33%
`sign_open`	✅	4s	6s	-33%
`sign_signature`	✅	4s	5s	-20%
`sign_verify`	✅	4s	2s	+100%
`sign_verify_pre_hash_internal`	✅	4s	5s	-20%
`sign_verify_pre_hash_shake256`	✅	4s	4s	+0%
`unpack_pk`	✅	4s	6s	-33%
`use_hint`	✅	4s	3s	+33%
`intt_native_x86_64`	✅	3s	5s	-40%
`keccak_squeeze`	✅	3s	4s	-25%
`keccakf1600_extract_bytes (big endian)`	✅	3s	3s	+0%
`mld_ct_abs_i32`	✅	3s	2s	+50%
`mld_ct_get_optblocker_u32`	✅	3s	2s	+50%
`mld_keccakf1600_extract_bytes`	✅	3s	1s	+200%
`mld_value_barrier_u32`	✅	3s	2s	+50%
`pack_sig_z`	✅	3s	3s	+0%
`poly_add`	✅	3s	4s	-25%
`poly_chknorm_native`	✅	3s	2s	+50%
`poly_decompose_native`	✅	3s	5s	-40%
`poly_invntt_tomont`	✅	3s	2s	+50%
`poly_make_hint`	✅	3s	2s	+50%
`poly_pointwise_montgomery_native`	✅	3s	3s	+0%
`poly_power2round`	✅	3s	3s	+0%
`poly_reduce`	✅	3s	4s	-25%
`poly_use_hint`	✅	3s	3s	+0%
`poly_use_hint_c`	✅	3s	4s	-25%
`poly_use_hint_native`	✅	3s	4s	-25%
`polyeta_pack`	✅	3s	4s	-25%
`polyt1_pack`	✅	3s	2s	+50%
`polyt1_unpack`	✅	3s	3s	+0%
`polyveck_pack_eta`	✅	3s	2s	+50%
`polyveck_pack_t0`	✅	3s	2s	+50%
`polyvecl_pointwise_acc_montgomery`	✅	3s	4s	-25%
`polyvecl_unpack_z`	✅	3s	3s	+0%
`rej_eta`	✅	3s	2s	+50%
`shake128_init`	✅	3s	2s	+50%
`shake128_release`	✅	3s	3s	+0%
`shake128x4_squeezeblocks`	✅	3s	2s	+50%
`shake256`	✅	3s	4s	-25%
`shake256_squeeze`	✅	3s	2s	+50%
`shake256x4_squeezeblocks`	✅	3s	1s	+200%
`sign_signature_extmu`	✅	3s	5s	-40%
`sys_check_capability`	✅	3s	3s	+0%
`fqscale`	✅	2s	5s	-60%
`keccak_finalize`	✅	2s	2s	+0%
`keccak_init`	✅	2s	3s	-33%
`keccakf1600_xor_bytes (big endian)`	✅	2s	3s	-33%
`keccakf1600x4_extract_bytes`	✅	2s	2s	+0%
`make_hint`	✅	2s	5s	-60%
`mld_ct_cmask_neg_i32`	✅	2s	1s	+100%
`mld_ct_get_optblocker_u8`	✅	2s	2s	+0%
`mld_value_barrier_u8`	✅	2s	2s	+0%
`pack_sig_c_h`	✅	2s	3s	-33%
`poly_caddq_c`	✅	2s	3s	-33%
`poly_decompose`	✅	2s	3s	-33%
`poly_pointwise_montgomery`	✅	2s	4s	-50%
`poly_shiftl`	✅	2s	2s	+0%
`polyveck_unpack_eta`	✅	2s	3s	-33%
`polyvecl_pointwise_acc_montgomery_native`	✅	2s	3s	-33%
`polyvecl_unpack_eta`	✅	2s	3s	-33%
`polyw1_pack`	✅	2s	2s	+0%
`polyz_unpack_native`	✅	2s	4s	-50%
`power2round`	✅	2s	4s	-50%
`reduce32`	✅	2s	4s	-50%
`shake128_absorb`	✅	2s	2s	+0%
`shake256_init`	✅	2s	2s	+0%
`shake256x4_absorb_once`	✅	2s	2s	+0%
`mld_ct_cmask_nonzero_u8`	✅	1s	3s	-67%
`shake128_finalize`	✅	1s	3s	-67%
`shake128_squeeze`	✅	1s	5s	-80%
`shake256_finalize`	✅	1s	3s	-67%

oqs-bot · 2026-02-10T03:40:36Z

CBMC Results (ML-DSA-65)

⚠️ Attention Required

Proof	Status	Current	Previous	Change
`sign_verify_internal`	⚠️	293s	177s	+66%

Full Results (175 proofs)

Proof	Status	Current	Previous	Change
`TOTAL`	✅	2406s	2286s	+5.2%
`sign_verify_internal`	⚠️	293s	177s	+66%
`mld_attempt_signature_generation`	✅	225s	197s	+14%
`polyvecl_pointwise_acc_montgomery_c`	✅	225s	226s	-0%
`rej_uniform_native`	✅	143s	144s	-1%
`polyvec_matrix_expand`	✅	142s	145s	-2%
`poly_pointwise_montgomery_c`	✅	132s	138s	-4%
`mld_invntt_layer`	✅	115s	117s	-2%
`mld_ct_memcmp`	✅	84s	79s	+6%
`polyvec_matrix_expand_serial`	✅	64s	65s	-2%
`mld_ntt_layer`	✅	43s	44s	-2%
`keccak_squeezeblocks_x4`	✅	42s	42s	+0%
`sign_signature_internal`	✅	42s	50s	-16%
`mld_compute_t0_t1_tr_from_sk_components`	✅	24s	27s	-11%
`polymat_permute_bitrev_to_custom`	✅	22s	18s	+22%
`rej_uniform`	✅	19s	21s	-10%
`fqmul`	✅	18s	18s	+0%
`poly_uniform_eta_4x`	✅	17s	17s	+0%
`polyt0_unpack`	✅	17s	17s	+0%
`rej_uniform_c`	✅	17s	19s	-11%
`poly_chknorm_c`	✅	16s	16s	+0%
`polyveck_decompose`	✅	16s	16s	+0%
`mld_polyvecl_permute_bitrev_to_custom_native`	✅	15s	14s	+7%
`poly_uniform_4x`	✅	15s	13s	+15%
`keccakf1600x4_permute_native`	✅	14s	14s	+0%
`polyvec_matrix_pointwise_montgomery`	✅	14s	14s	+0%
`mld_ntt_butterfly_block`	✅	13s	13s	+0%
`poly_invntt_tomont_c`	✅	12s	8s	+50%
`polyveck_use_hint`	✅	11s	14s	-21%
`keccak_absorb_once_x4`	✅	10s	10s	+0%
`poly_decompose_c`	✅	10s	7s	+43%
`sign_pk_from_sk`	✅	10s	8s	+25%
`polyveck_add`	✅	9s	9s	+0%
`polyveck_caddq`	✅	9s	8s	+12%
`polyveck_invntt_tomont`	✅	9s	8s	+12%
`polyveck_ntt`	✅	9s	6s	+50%
`polyveck_power2round`	✅	9s	11s	-18%
`polyveck_reduce`	✅	9s	9s	+0%
`polyvecl_ntt`	✅	9s	8s	+12%
`keccakf1600_permute`	✅	8s	9s	-11%
`polyveck_pointwise_poly_montgomery`	✅	8s	6s	+33%
`polyveck_sub`	✅	8s	7s	+14%
`sign_signature_pre_hash_internal`	✅	8s	6s	+33%
`keccakf1600_permute_native`	✅	7s	9s	-22%
`mld_sample_s1_s2_serial`	✅	7s	6s	+17%
`keccak_absorb`	✅	6s	5s	+20%
`mld_compute_pack_z`	✅	6s	7s	-14%
`mld_prepare_domain_separation_prefix`	✅	6s	5s	+20%
`polyveck_shiftl`	✅	6s	8s	-25%
`polyz_unpack_c`	✅	6s	5s	+20%
`sign_open`	✅	6s	5s	+20%
`keccakf1600_extract_bytes (big endian)`	✅	5s	3s	+67%
`mld_check_pct`	✅	5s	9s	-44%
`mld_sample_s1_s2`	✅	5s	4s	+25%
`ntt_native_x86_64`	✅	5s	3s	+67%
`poly_add`	✅	5s	4s	+25%
`poly_decompose_native`	✅	5s	3s	+67%
`poly_sub`	✅	5s	5s	+0%
`poly_uniform_eta`	✅	5s	3s	+67%
`poly_uniform_gamma1_4x`	✅	5s	6s	-17%
`poly_use_hint_c`	✅	5s	7s	-29%
`polyeta_unpack`	✅	5s	7s	-29%
`polyveck_make_hint`	✅	5s	5s	+0%
`polyz_pack`	✅	5s	4s	+25%
`rej_eta_c`	✅	5s	3s	+67%
`shake256_init`	✅	5s	2s	+150%
`shake256x4_squeezeblocks`	✅	5s	3s	+67%
`sign`	✅	5s	9s	-44%
`sign_signature`	✅	5s	4s	+25%
`sign_signature_extmu`	✅	5s	4s	+25%
`sign_verify`	✅	5s	4s	+25%
`unpack_hints`	✅	5s	5s	+0%
`unpack_sk`	✅	5s	5s	+0%
`use_hint`	✅	5s	2s	+150%
`fqscale`	✅	4s	4s	+0%
`keccakf1600_xor_bytes`	✅	4s	3s	+33%
`keccakf1600x4_permute`	✅	4s	1s	+300%
`keccakf1600x4_xor_bytes`	✅	4s	2s	+100%
`mld_h`	✅	4s	3s	+33%
`mld_keccakf1600_extract_bytes`	✅	4s	2s	+100%
`pack_sig_z`	✅	4s	2s	+100%
`pack_sk`	✅	4s	2s	+100%
`poly_caddq_c`	✅	4s	3s	+33%
`poly_challenge`	✅	4s	4s	+0%
`poly_chknorm_native`	✅	4s	4s	+0%
`poly_invntt_tomont_native`	✅	4s	7s	-43%
`poly_ntt_native`	✅	4s	3s	+33%
`poly_uniform`	✅	4s	4s	+0%
`poly_use_hint_native`	✅	4s	4s	+0%
`polyt0_pack`	✅	4s	4s	+0%
`polyveck_pack_eta`	✅	4s	4s	+0%
`polyveck_unpack_t0`	✅	4s	3s	+33%
`polyvecl_chknorm`	✅	4s	5s	-20%
`polyvecl_permute_bitrev_to_custom`	✅	4s	3s	+33%
`polyvecl_pointwise_acc_montgomery_native`	✅	4s	5s	-20%
`polyvecl_uniform_gamma1`	✅	4s	5s	-20%
`polyvecl_uniform_gamma1_serial`	✅	4s	4s	+0%
`polyz_unpack`	✅	4s	2s	+100%
`rej_eta_native`	✅	4s	4s	+0%
`shake128_absorb`	✅	4s	2s	+100%
`shake128x4_squeezeblocks`	✅	4s	1s	+300%
`shake256_release`	✅	4s	1s	+300%
`sign_keypair_internal`	✅	4s	6s	-33%
`sign_verify_extmu`	✅	4s	4s	+0%
`sign_verify_pre_hash_shake256`	✅	4s	6s	-33%
`sys_check_capability`	✅	4s	3s	+33%
`decompose`	✅	3s	5s	-40%
`keccak_squeeze`	✅	3s	2s	+50%
`keccakf1600_xor_bytes (big endian)`	✅	3s	3s	+0%
`keccakf1600x4_extract_bytes`	✅	3s	1s	+200%
`make_hint`	✅	3s	3s	+0%
`mld_ct_abs_i32`	✅	3s	4s	-25%
`mld_ct_cmask_nonzero_u8`	✅	3s	2s	+50%
`mld_ct_get_optblocker_i64`	✅	3s	1s	+200%
`mld_ct_get_optblocker_u32`	✅	3s	4s	-25%
`mld_ct_get_optblocker_u8`	✅	3s	2s	+50%
`mld_value_barrier_i64`	✅	3s	2s	+50%
`mld_value_barrier_u32`	✅	3s	3s	+0%
`pack_sig_c_h`	✅	3s	2s	+50%
`poly_caddq`	✅	3s	3s	+0%
`poly_decompose`	✅	3s	3s	+0%
`poly_invntt_tomont`	✅	3s	6s	-50%
`poly_ntt`	✅	3s	5s	-40%
`poly_ntt_c`	✅	3s	2s	+50%
`poly_pointwise_montgomery`	✅	3s	5s	-40%
`poly_pointwise_montgomery_native`	✅	3s	2s	+50%
`poly_power2round`	✅	3s	5s	-40%
`poly_reduce`	✅	3s	5s	-40%
`poly_uniform_gamma1`	✅	3s	5s	-40%
`poly_use_hint`	✅	3s	3s	+0%
`polyeta_pack`	✅	3s	2s	+50%
`polyveck_chknorm`	✅	3s	5s	-40%
`polyveck_pack_t0`	✅	3s	3s	+0%
`polyveck_pack_w1`	✅	3s	6s	-50%
`polyveck_unpack_eta`	✅	3s	4s	-25%
`polyvecl_pack_eta`	✅	3s	4s	-25%
`polyvecl_pointwise_acc_montgomery`	✅	3s	5s	-40%
`polyz_unpack_native`	✅	3s	3s	+0%
`shake128_release`	✅	3s	3s	+0%
`shake128_squeeze`	✅	3s	2s	+50%
`shake128x4_absorb_once`	✅	3s	4s	-25%
`shake256_finalize`	✅	3s	5s	-40%
`shake256_squeeze`	✅	3s	2s	+50%
`sign_keypair`	✅	3s	3s	+0%
`sign_signature_pre_hash_shake256`	✅	3s	4s	-25%
`sign_verify_pre_hash_internal`	✅	3s	3s	+0%
`unpack_pk`	✅	3s	3s	+0%
`caddq`	✅	2s	3s	-33%
`intt_native_x86_64`	✅	2s	3s	-33%
`keccak_finalize`	✅	2s	2s	+0%
`keccak_init`	✅	2s	3s	-33%
`mld_ct_cmask_neg_i32`	✅	2s	2s	+0%
`mld_ct_cmask_nonzero_u32`	✅	2s	2s	+0%
`mld_ct_sel_int32`	✅	2s	3s	-33%
`mld_value_barrier_u8`	✅	2s	3s	-33%
`pack_pk`	✅	2s	3s	-33%
`poly_caddq_native`	✅	2s	4s	-50%
`poly_caddq_native_aarch64`	✅	2s	6s	-67%
`poly_chknorm`	✅	2s	3s	-33%
`poly_make_hint`	✅	2s	3s	-33%
`poly_shiftl`	✅	2s	2s	+0%
`polyt1_unpack`	✅	2s	6s	-67%
`polyvecl_unpack_eta`	✅	2s	5s	-60%
`polyvecl_unpack_z`	✅	2s	2s	+0%
`polyw1_pack`	✅	2s	1s	+100%
`power2round`	✅	2s	2s	+0%
`reduce32`	✅	2s	3s	-33%
`rej_eta`	✅	2s	4s	-50%
`shake128_init`	✅	2s	1s	+100%
`shake256`	✅	2s	2s	+0%
`shake256_absorb`	✅	2s	5s	-60%
`shake256x4_absorb_once`	✅	2s	4s	-50%
`unpack_sig`	✅	2s	4s	-50%
`montgomery_reduce`	✅	1s	2s	-50%
`polyt1_pack`	✅	1s	2s	-50%
`shake128_finalize`	✅	1s	3s	-67%

In mld_sign if a failure is returned from mld_sign_signature, we currently set the smlen to mlen (mld_sign_signature returns smlen=0, and we increment it by mlen). This commit changes it so that in the case of failure smlen=0 is returned. Signed-off-by: Matthias J. Kannwischer <matthias@kannwischer.eu>

This commit adds a reference to FIPS204 that states that t0 does not need to be considered secret. That replaces an old reference to an eprint report stating the same. Signed-off-by: Matthias J. Kannwischer <matthias@kannwischer.eu>

rod-chapman · 2026-02-23T10:15:58Z

mldsa/src/sign.c

  ret = mld_sign_signature(sm, smlen, sm + MLDSA_CRYPTO_BYTES, mlen, ctx,
                           ctxlen, sk, context);
-  *smlen += mlen;
+  if (ret == 0)


Please update the comment(s) and the ensures contract for this function in sign.h
(or is it deliberately left under-specified?)

Do the comments at the top-level API in mldsa/mldsa_native.h also need to be updated?

I think the contract and comments exactly what we want to guarantee:
(return_value == 0 && *smlen == MLDSA_CRYPTO_BYTES + mlen)
WDYT @hanno-becker?

In the long term I think we should rather consider eliminating smlen altogether - see #789.

In the failure case(s), should we write *smlen==0 in the ensures clause, or leave it unspecified?

mkannwischer marked this pull request as ready for review February 10, 2026 03:54

mkannwischer requested a review from a team as a code owner February 10, 2026 03:54

mkannwischer mentioned this pull request Feb 23, 2026

Inconsistent and possibly confusing mld_sign() API and contracts #974

Open

rod-chapman self-requested a review February 23, 2026 10:08

mkannwischer added 2 commits February 23, 2026 10:09

rod-chapman force-pushed the smlen branch from 42ed215 to 134bfe1 Compare February 23, 2026 10:09

rod-chapman reviewed Feb 23, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sign: Set smlen to 0 in case of failure#959

Sign: Set smlen to 0 in case of failure#959
mkannwischer wants to merge 2 commits intomainfrom
smlen

mkannwischer commented Feb 10, 2026 •

edited

Loading

Uh oh!

oqs-bot commented Feb 10, 2026 •

edited

Loading

Uh oh!

oqs-bot commented Feb 10, 2026 •

edited

Loading

Uh oh!

oqs-bot commented Feb 10, 2026 •

edited

Loading

Uh oh!

rod-chapman Feb 23, 2026

Uh oh!

rod-chapman Feb 23, 2026

Uh oh!

mkannwischer Feb 24, 2026

Uh oh!

rod-chapman Feb 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

mkannwischer commented Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oqs-bot commented Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CBMC Results (ML-DSA-44)

Uh oh!

oqs-bot commented Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CBMC Results (ML-DSA-87)

Uh oh!

oqs-bot commented Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CBMC Results (ML-DSA-65)

Uh oh!

rod-chapman Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

rod-chapman Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

mkannwischer Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

rod-chapman Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mkannwischer commented Feb 10, 2026 •

edited

Loading

oqs-bot commented Feb 10, 2026 •

edited

Loading

oqs-bot commented Feb 10, 2026 •

edited

Loading

oqs-bot commented Feb 10, 2026 •

edited

Loading