This repository was archived by the owner on Dec 20, 2025. It is now read-only.
Open
Conversation
cothan
force-pushed
the
add_default_pqm4_board
branch
2 times, most recently
from
7279b2f to
3434731
Compare
mkannwischer
suggested changes
Oct 22, 2024
Contributor
mkannwischer
left a comment
mkannwischer
left a comment
There was a problem hiding this comment.
Thanks for adding this @cothan.
Works fine and looking mostly good.
Can you make the following changes/answer my questions please?
Signed-off-by: Duc Tri Nguyen <9219016+cothan@users.noreply.github.com> format Signed-off-by: Duc Tri Nguyen <9219016+cothan@users.noreply.github.com> revert the changes to libopencm3
cothan
force-pushed
the
add_default_pqm4_board
branch
from
3434731 to
ee07cad
Compare
mkannwischer
suggested changes
Oct 23, 2024
Contributor
mkannwischer
left a comment
mkannwischer
left a comment
There was a problem hiding this comment.
If I am running
tests stack nucleo-l4r5zi -v
I'm getting the following
DEBUG > Waiting for start marker
DEBUG > Reading input
DEBUG > keypair stack usage:
4294967268
encaps stack usage:
4294967268
decaps stack usage:
4294967268
OK KEYS
That looks wrong. Do you also see that? Can you look into that, please? Stack measurements are always a bit fragile, unfortunately.
Author
|
@mkannwischer , I confirm I see the same problem. I'm not sure why, all the code I copy from pqm4 repo. I'll look into it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #54