HOL-Light: x86 INTT output bound <=26632 -> <=26631 #1394
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkannwischer
force-pushed
the
hol-light-fix-intt-bound
branch
3 times, most recently
from
76a780f to
3c005aa
Compare
hanno-becker
approved these changes
Dec 16, 2025
mkannwischer
added a commit
to mkannwischer/s2n-bignum
that referenced
this pull request
Dec 16, 2025
While integrating the x86 ML-KEM inverse NTT proof into mlkem-native (more specifically when adding the corresponding CBMC contract and trying to prove it's adherence to out API contracts), we noticed that the output bound in the HOL-Light specification is off by one: mlkem-native requires < 26632 = 8*q, while the HOL-Light specification states <= 26632. This commit corrects the specification. No change to the proof is required. - See pq-code-package/mlkem-native#1394 Signed-off-by: Matthias J. Kannwischer <[email protected]>
mkannwischer
added a commit
to mkannwischer/s2n-bignum
that referenced
this pull request
Dec 16, 2025
While integrating the x86 ML-KEM inverse NTT proof into mlkem-native (more specifically when adding the corresponding CBMC contract and trying to prove its adherence to out API contracts), we noticed that the output bound in the HOL-Light specification is off by one: mlkem-native requires < 26632 (8q), while the HOL-Light specification states <= 26632. This commit corrects the specification. No change to the proof is required. - See pq-code-package/mlkem-native#1394 Signed-off-by: Matthias J. Kannwischer <[email protected]>
mkannwischer
added a commit
to mkannwischer/s2n-bignum
that referenced
this pull request
Dec 16, 2025
While integrating the x86 ML-KEM inverse NTT proof into mlkem-native (more specifically when adding the corresponding CBMC contract and trying to prove its adherence to the API contracts), we noticed that the output bound in the HOL-Light specification is off by one: mlkem-native requires < 26632 (8q), while the HOL-Light specification states <= 26632. This commit corrects the specification. No change to the proof is required. - See pq-code-package/mlkem-native#1394 Signed-off-by: Matthias J. Kannwischer <[email protected]>
hanno-becker
force-pushed
the
hol-light-fix-intt-bound
branch
from
3c005aa to
fb3ed8b
Compare
Contributor
Author
|
Merged as a part of #1383 |
jargh
pushed a commit
to awslabs/s2n-bignum
that referenced
this pull request
Dec 20, 2025
While integrating the x86 ML-KEM inverse NTT proof into mlkem-native (more specifically when adding the corresponding CBMC contract and trying to prove its adherence to the API contracts), we noticed that the output bound in the HOL-Light specification is off by one: mlkem-native requires < 26632 (8q), while the HOL-Light specification states <= 26632. This commit corrects the specification. No change to the proof is required. - See pq-code-package/mlkem-native#1394 Signed-off-by: Matthias J. Kannwischer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During #1393, we noticed that the HOL-Light proof for the x86 INTT proves the bound <=26632, while our contract requires <= 26631.
This commit corrects the bound in the HOL-Light specification.