Namespace macro in KeccakP_1600_times4_SIMD256.c #1407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willieyz
force-pushed
the
namespace-KeccakP_1600_times4_SIMD256
branch
from
cc2afa7 to
55436e2
Compare
Contributor
There was a problem hiding this comment.
No need to change keccakf1600.c - these are just comments.
Contributor
Author
There was a problem hiding this comment.
Hello, @mkannwischer , thank you for your review,
I had removed all change in keccakf1600.c, thank you!
- This commit add namespace MLK_ for all macros in KeccakP_1600_time4_SIMD256.c Signed-off-by: willieyz <[email protected]>
willieyz
force-pushed
the
namespace-KeccakP_1600_times4_SIMD256
branch
from
55436e2 to
4876342
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: Namespace STACK_SIZE mldsa-native#796 (review)
This Pull Request namespace all macro in
KeccakP_1600_times4_SIMD256.c, similar with Namespace KeccakP_1600_times4_SIMD256.c with MLD_ mldsa-native#803