Add SPDX headers and copyright notices at the beginning of files.#93
Open
adrien-n wants to merge 1 commit intopq-crystals:mainfrom
Open
Add SPDX headers and copyright notices at the beginning of files.#93adrien-n wants to merge 1 commit intopq-crystals:mainfrom
adrien-n wants to merge 1 commit intopq-crystals:mainfrom
Conversation
In downstream projects, files may be copied and moved around. This makes it difficult to track the copyrights and licenses without having them stored in each file. License and copyright holders for files without specific header is assumed to be the one in LICENSE and AUTHORS.md files respectively.
|
@adrien-n Maybe you do want to consider switching to a more actively maintained implementation https://github.com/pq-code-package/mlkem-native. This is a continuation of the reference implementation in this repository. It in particular applies the diligence regarding SPDX license identifiers that you ask for. |
danalec
added a commit
to danalec/kyber
that referenced
this pull request
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In downstream projects, files may be copied and moved around. This makes it difficult to track the copyrights and licenses without having them stored in each file.
License and copyright holders for files without specific header is assumed to be the one in LICENSE and AUTHORS.md files respectively.
This is similar to pq-crystals/dilithium#99 and shares roughly the same limitation. This time I didn't copy the header for
ref/fips202.hfromref/fips202.chowever; this reflects how parted I am with this file: because the current statements and what I can guess (i.e. same as the.cfile) differ. I guess this will need some back-and-forth before these MRs can be merged; I hope I can make that as seamless as possible.