fix: detect visibility:hidden for hidden state#1066
Open
People-Sea wants to merge 1 commit intopqina:masterfrom
Open
fix: detect visibility:hidden for hidden state#1066People-Sea wants to merge 1 commit intopqina:masterfrom
People-Sea wants to merge 1 commit intopqina:masterfrom
Conversation
People-Sea
force-pushed
the
fix/visibility-hidden-detection
branch
from
448aefd to
ef97595
Compare
Collaborator
|
@People-Sea thanks for the PR, happy to revisit this when v5 is out of beta |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FilePond only checks
offsetParent === nullto determine if the element is hidden, which works fordisplay: nonebut not forvisibility: hidden.When FilePond is placed in containers using
visibility: hidden(common in tab components), the render loop sleeps while hidden but doesn't wake up when becoming visible—because the visibility check only looks atoffsetParent.This adds
style.visibility === 'hidden'to the hidden state detection so the render loop properly resumes when the container becomes visible.Reproduction https://codesandbox.io/p/sandbox/broken-frog-yysqdr?file=%2Findex.html