fix: aborting a completed item reverts the first file instead of the target#1068
Open
People-Sea wants to merge 1 commit intopqina:masterfrom
Open
fix: aborting a completed item reverts the first file instead of the target#1068People-Sea wants to merge 1 commit intopqina:masterfrom
People-Sea wants to merge 1 commit intopqina:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When clicking the abort button on a file that has already finished processing (animation still playing),
ABORT_ITEM_PROCESSINGdispatchesREVERT_ITEM_PROCESSINGwith{ id: item.id }instead of{ query: item.id }. This causesgetItemByQueryFromStateto receiveundefinedforquery, which makesgetItemByQueryreturnitems[0]— always reverting the first file in the list.Steps to reproduce
Upload multiple files with maxParallelUploads set high (or fast connection)
Click the abort button on the second file while the completion animation is still playing
The first file gets reverted instead
Fix
Before / After
Before (wrong file gets reverted):
before.mov
After (correct file gets reverted):
after.mov