Fixed no response return onload callback#631
Open
Yahasana wants to merge 1 commit intopqina:masterfrom
Open
Conversation
If there is nothing return from `onload` callback, use xhr.response by default
Collaborator
|
There is no related issue. This is also not a bug. Please in future first submit issue with bug report then we can discuss a PR. |
Author
|
It's not a bug, but it's a bad implement. It's take me a whole day to investigate what the hell of failing revert upload. e.g. FilePond.setOptions({
server: {
process: {
method: "POST",
onload: (response) => {
console.log(response)
// return response <-- revert upload by serverId rely on this return! wtf
}
}
}) |
Collaborator
|
I'm not comfortable changing this behaviour at this point in time. If you set This will go wrong when dev returns onload(xhr.response) || xhr.response, |
Collaborator
|
Will re-open, PR should be updated to fix above issue with falsy values. |
Author
|
why people returns |
Collaborator
|
@Yahasana file server id could potentially |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If there is nothing return from
onloadcallback, usexhr.responseby default