Skip to content

Commit 92c59d8

Browse files
HeidiHan0000pradeepvaka
authored andcommitted
Add requestDataSizesMaxWaitSec to Prestissimo system configs (prestodb#24774) (prestodb#24774)
Summary: as title Differential Revision: D71572165
1 parent f900d50 commit 92c59d8

File tree

3 files changed

+24
-2
lines changed

3 files changed

+24
-2
lines changed

presto-docs/src/main/sphinx/presto_cpp/properties.rst

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
Presto C++ Configuration Properties
33
===================================
44

5-
This section describes Presto C++ configuration properties.
5+
This section describes Presto C++ configuration properties.
66

77
The following is not a complete list of all configuration properties,
88
and does not include any connector-specific catalog configuration properties
@@ -429,7 +429,7 @@ The configuration properties of AsyncDataCache and SSD cache are described here.
429429
* **Type:** ``integer``
430430
* **Default value:** ``0``
431431

432-
The size of the SSD. Unit is in GiB (gibibytes).
432+
The size of the SSD. Unit is in GiB (gibibytes).
433433

434434
``async-cache-ssd-path``
435435
^^^^^^^^^^^^^^^^^^^^^^^^
@@ -529,6 +529,17 @@ The configuration properties of AsyncDataCache and SSD cache are described here.
529529

530530
The periodic duration to apply cache TTL and evict AsyncDataCache and SSD cache entries.
531531

532+
Exchange Properties
533+
-------------------
534+
535+
``exchange.http-client.request-data-sizes-max-wait-sec``
536+
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
537+
538+
* **Type:** ``integer``
539+
* **Default value:** ``10``
540+
541+
Maximum wait time for exchange request in seconds.
542+
532543
Memory Checker Properties
533544
-------------------------
534545

presto-native-execution/presto_cpp/main/common/Configs.cpp

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -254,6 +254,7 @@ SystemConfig::SystemConfig() {
254254
BOOL_PROP(kJoinSpillEnabled, true),
255255
BOOL_PROP(kAggregationSpillEnabled, true),
256256
BOOL_PROP(kOrderBySpillEnabled, true),
257+
NUM_PROP(kRequestDataSizesMaxWaitSec, 10),
257258
};
258259
}
259260

@@ -333,6 +334,10 @@ bool SystemConfig::orderBySpillEnabled() const {
333334
return optionalProperty<bool>(kOrderBySpillEnabled).value();
334335
}
335336

337+
int SystemConfig::requestDataSizesMaxWaitSec() const {
338+
return optionalProperty<int>(kRequestDataSizesMaxWaitSec).value();
339+
}
340+
336341
bool SystemConfig::mutableConfig() const {
337342
return optionalProperty<bool>(kMutableConfig).value();
338343
}

presto-native-execution/presto_cpp/main/common/Configs.h

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -721,6 +721,10 @@ class SystemConfig : public ConfigBase {
721721
static constexpr std::string_view kOrderBySpillEnabled{
722722
"order-by-spill-enabled"};
723723

724+
// Max wait time for exchange request in seconds.
725+
static constexpr std::string_view kRequestDataSizesMaxWaitSec{
726+
"exchange.http-client.request-data-sizes-max-wait-sec"};
727+
724728
SystemConfig();
725729

726730
virtual ~SystemConfig() = default;
@@ -983,6 +987,8 @@ class SystemConfig : public ConfigBase {
983987
bool aggregationSpillEnabled() const;
984988

985989
bool orderBySpillEnabled() const;
990+
991+
int requestDataSizesMaxWaitSec() const;
986992
};
987993

988994
/// Provides access to node properties defined in node.properties file.

0 commit comments

Comments
 (0)