_code.sass: use :has selector for .highlight's parent div #893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current selectors `div[class*=" highlight-"]` and `div[class^=highlight-]` are slow on larger pages (such as generated docs) with many divs. Use the more modern `:has(...)` to speed it up. In one example it goes from 160'018 match attempts to just 280 match attempts, to apply to 66 elements in either case. The selector is not equivalent because it's not testing whether the parent has a `highlight-*` class, but I think we can always expect a combination `<div class="highlight-foo"><div class="highlight">...</div></div>`?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current selectors
div[class*=" highlight-"]anddiv[class^=highlight-]are slow on larger pages with generated API docs. Use the more modern:has(...)to speed it up.In one example it goes from 160'018 match attempts to just 280 match attempts, to ultimately apply to just 66 elements.
The selector is not exactly equivalent because it's not testing whether the parent has a
highlight-*class, but I think we can always expect a combination<div class="highlight-foo"><div class="highlight">...</div></div>when using Sphinx.