Merged
Conversation
added 30 commits
October 17, 2024 10:25
… or 'raise ... from None'
…ps])' instead of 'for' loop
added 6 commits
October 21, 2024 11:21
erikh360
reviewed
Oct 23, 2024
Contributor
erikh360
left a comment
erikh360
left a comment
There was a problem hiding this comment.
Nice, just the two small changes
jerith
reviewed
Oct 23, 2024
eventstore/tests/test_views.py
Outdated
| ) | ||
| (self.assertEqual(messages.id, "9e12d04c-af25-40b6-aa4f-57c72e8e3f91"),) | ||
| (self.assertEqual(messages.type, "image"),) | ||
| (self.assertEqual(messages.message_direction, Message.INBOUND),) |
Member
There was a problem hiding this comment.
This looks like ruff has helpfully turned a bunch of accidental trailing commas into explicit tuples. Perhaps we should remove the commas instead?
Member
There was a problem hiding this comment.
I think there are more of these -- mostly multiline ones. Any line that starts (self.assert... or the multiline equivalent with the ( on the line above can be de-tupled.
erikh360
approved these changes
Nov 14, 2024
erikh360
approved these changes
Jul 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is for the repo consistency work done on this repo.
The main goal is getting all repos to use poetry for package management, and ruff for linting.