fix: prevent GC from collecting DataExtract buffers#7
Open
chvancooten wants to merge 2 commits intopraetorian-inc:mainfrom
Open
fix: prevent GC from collecting DataExtract buffers#7chvancooten wants to merge 2 commits intopraetorian-inc:mainfrom
chvancooten wants to merge 2 commits intopraetorian-inc:mainfrom
Conversation
DataExtract allocates a Go slice to hold extracted data and returns a raw uintptr to the caller (native BOF code). Since Go's GC doesn't track uintptr values, the backing array could be collected before the BOF finishes using it, causing memory corruption and garbled data. This fix stores extracted buffers in a global map, keeping them alive for the duration of the BOF execution. This prevents the GC from reclaiming the memory while it's still in use by native code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DataExtractallocates a Go slice to hold extracted data and returns a raw uintptr to the caller (native BOF code). Since Go's GC doesn't track uintptr values, the backing array could be collected before the BOF finishes using it, causing memory corruption and garbled data. We encountered this issue for example in Outflank's Kerberoast BOF.This fix stores extracted buffers in a global map keyed by their pointer address, keeping them alive for the duration of the BOF execution. Buffers are cleaned up when BeaconDataFree is called.