Skip to content

fix: wrong struct type#712

Merged
jeluard merged 1 commit intomainfrom
jeluard/release-limit
Mar 5, 2026
Merged

fix: wrong struct type#712
jeluard merged 1 commit intomainfrom
jeluard/release-limit

Conversation

@jeluard
Copy link
Contributor

@jeluard jeluard commented Mar 5, 2026

Summary by CodeRabbit

  • Chores
    • Updated rate-limit configuration structure from a single numeric value to a table format with separate settings for new and existing packages, requiring configuration file updates.

Signed-off-by: jeluard <jeluard@users.noreply.github.com>
Copilot AI review requested due to automatic review settings March 5, 2026 13:57
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 5, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 6f14c2dd-4700-436b-bd6b-ea744a4e83c3

📥 Commits

Reviewing files that changed from the base of the PR and between 928aa90 and 419893c.

📒 Files selected for processing (1)
  • release.toml

Walkthrough

The release.toml configuration file transitions the rate-limit setting from a single scalar value to a structured table format, splitting it into new-packages and existing-packages fields—both set to 20. This restructures the configuration schema while preserving existing behavior across other settings.

Changes

Cohort / File(s) Summary
Rate-limit Configuration Restructure
release.toml
Converted scalar rate-limit = 20 into a structured [rate-limit] table with separate new-packages and existing-packages fields, both set to 20. Schema change that enables differentiated rate-limit handling.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Possibly related PRs

  • fix: allow for first release #711: Introduced the original scalar rate-limit configuration that this PR restructures into a more granular table format with package-type differentiation.

Poem

🎬 The rate-limit's had a glow-up, mate,
From scalar to a structured state,
New packages and the old ones too,
Now get their own config view! 🎮

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: converting a scalar rate-limit setting to a structured table with proper type definition, fixing the configuration structure.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch jeluard/release-limit

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the cargo-release workspace configuration to use the newer structured rate-limit configuration format.

Changes:

  • Replaces scalar rate-limit = 20 with a structured rate-limit configuration containing separate limits for new vs existing packages.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +32 to 37
[rate-limit]
new-packages = 20
existing-packages = 20

# Let cargo-release verify the tree is clean before proceeding
pre-release-commit-message = "chore: release {{version}}"
Copy link

Copilot AI Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Defining [rate-limit] here turns all subsequent keys (e.g. pre-release-commit-message, tag-message, tag-name) into fields of the rate-limit table in TOML, which likely breaks cargo-release config parsing. Use dotted keys (rate-limit.new-packages, rate-limit.existing-packages), an inline table (rate-limit = { ... }), or move the [rate-limit] table to the end of the file so later settings remain top-level.

Copilot uses AI. Check for mistakes.
@codecov
Copy link

codecov bot commented Mar 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
see 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jeluard jeluard merged commit d57c82a into main Mar 5, 2026
44 of 45 checks passed
@jeluard jeluard deleted the jeluard/release-limit branch March 5, 2026 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants