Skip to content

fix: use amaru-uplc-turbo#714

Closed
jeluard wants to merge 3 commits intomainfrom
jeluard/amaru-uplc-turbo
Closed

fix: use amaru-uplc-turbo#714
jeluard wants to merge 3 commits intomainfrom
jeluard/amaru-uplc-turbo

Conversation

@jeluard
Copy link
Contributor

@jeluard jeluard commented Mar 5, 2026

Summary by CodeRabbit

  • Chores
    • Replaced a git-based dependency with a published crate release (amaru-uplc-turbo v0.1.0).
    • Renamed public dependency references from the previous name to amaru-uplc-turbo across manifests.
    • Added package metadata to mark the renamed crate as ignored by internal tooling and align manifest behavior.

Signed-off-by: jeluard <jeluard@users.noreply.github.com>
Copilot AI review requested due to automatic review settings March 5, 2026 15:48
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 5, 2026

Warning

Rate limit exceeded

@jeluard has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 24 minutes and 14 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 6b506b12-b6d6-491d-a583-c99a74fd521f

📥 Commits

Reviewing files that changed from the base of the PR and between 021fec5 and 2000afa.

📒 Files selected for processing (1)
  • crates/amaru-plutus/Cargo.toml

Walkthrough

Replaced the git-based uplc-turbo workspace dependency with the versioned crate amaru-uplc-turbo = "0.1.0" in the workspace root and updated downstream references and crate metadata in crates/amaru-ledger and crates/amaru-plutus manifests.

Changes

Cohort / File(s) Summary
Workspace Dependency
Cargo.toml
Removed git-based uplc-turbo and added amaru-uplc-turbo = "0.1.0" under [workspace.dependencies].
Crate Manifests
crates/amaru-ledger/Cargo.toml, crates/amaru-plutus/Cargo.toml
Replaced uplc-turbo.workspace = true with amaru-uplc-turbo.workspace = true and added [package.metadata.cargo-machete] with ignored = ["amaru-uplc-turbo"].

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • KtorZ

Poem

A tidy swap, no git shanty in sight,
Amaru sails in, versioned and tight.
Manifests hum, Cargo gives a wink,
Build lights flicker — sip yer coffee, mate, don't blink. ☕️

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: switching from a git-based uplc-turbo dependency to a versioned amaru-uplc-turbo crate across multiple Cargo.toml files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch jeluard/amaru-uplc-turbo

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Switches the workspace from the uplc-turbo git dependency to the amaru-uplc-turbo crate.

Changes:

  • Replaces uplc-turbo with amaru-uplc-turbo in crate dependencies.
  • Updates workspace dependency source from git to a versioned crate (0.1.0).

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.

File Description
crates/amaru-plutus/Cargo.toml Updates dependency key from uplc-turbo to amaru-uplc-turbo.
crates/amaru-ledger/Cargo.toml Updates dependency key from uplc-turbo to amaru-uplc-turbo.
Cargo.toml Replaces the git dependency with a versioned amaru-uplc-turbo workspace dependency.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

amaru-tracing-json = { path = "crates/amaru-tracing-json", version = "0.1.1" }
pure-stage = { path = "crates/pure-stage", version = "0.1.1" }
uplc-turbo = { git = "https://github.com/pragma-org/uplc" }
amaru-uplc-turbo = "0.1.0"
Copy link

Copilot AI Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renaming the dependency key from uplc-turbo to amaru-uplc-turbo changes the crate identifier exposed to Rust code (from uplc_turbo to amaru_uplc_turbo). If the code still imports uplc_turbo, builds will fail. If the intent is to keep the existing crate name in code, define the workspace dependency under the old key and rename the package instead (e.g., keep uplc-turbo as the dependency name, with package = \"amaru-uplc-turbo\").

Suggested change
amaru-uplc-turbo = "0.1.0"
uplc-turbo = { package = "amaru-uplc-turbo", version = "0.1.0" }

Copilot uses AI. Check for mistakes.
[dependencies]
# External dependencies
uplc-turbo.workspace = true
amaru-uplc-turbo.workspace = true
Copy link

Copilot AI Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This dependency key change forces downstream code in this crate to reference the crate as amaru_uplc_turbo instead of uplc_turbo. If this PR is intended to be a drop-in replacement without touching Rust source imports, consider keeping the dependency name uplc-turbo here (and in the workspace) and using Cargo's package = \"amaru-uplc-turbo\" rename mechanism.

Suggested change
amaru-uplc-turbo.workspace = true
uplc-turbo = { workspace = true, package = "amaru-uplc-turbo" }

Copilot uses AI. Check for mistakes.
amaru-plutus.workspace = true
amaru-progress-bar.workspace = true
uplc-turbo.workspace = true
amaru-uplc-turbo.workspace = true
Copy link

Copilot AI Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same issue as in amaru-plutus: the dependency key determines the crate name used in Rust code. If existing imports expect uplc_turbo, this will break compilation unless the Rust source is updated accordingly. Prefer using a package = \"amaru-uplc-turbo\" rename while keeping the dependency name stable if you want compatibility.

Suggested change
amaru-uplc-turbo.workspace = true
uplc_turbo = { workspace = true, package = "amaru-uplc-turbo" }

Copilot uses AI. Check for mistakes.
@codecov
Copy link

codecov bot commented Mar 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
see 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: jeluard <jeluard@users.noreply.github.com>
@jeluard jeluard force-pushed the jeluard/amaru-uplc-turbo branch from 886d1b7 to 021fec5 Compare March 5, 2026 17:10
Signed-off-by: jeluard <jeluard@users.noreply.github.com>
@jeluard jeluard marked this pull request as draft March 5, 2026 17:14
@jeluard jeluard marked this pull request as ready for review March 5, 2026 17:14
@jeluard jeluard closed this Mar 5, 2026
@jeluard jeluard deleted the jeluard/amaru-uplc-turbo branch March 5, 2026 17:15
@jeluard jeluard restored the jeluard/amaru-uplc-turbo branch March 5, 2026 17:15
@jeluard jeluard deleted the jeluard/amaru-uplc-turbo branch March 5, 2026 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants