Conversation
Signed-off-by: jeluard <jeluard@users.noreply.github.com>
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughReplaced the git-based Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Switches the workspace from the uplc-turbo git dependency to the amaru-uplc-turbo crate.
Changes:
- Replaces
uplc-turbowithamaru-uplc-turboin crate dependencies. - Updates workspace dependency source from git to a versioned crate (
0.1.0).
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| crates/amaru-plutus/Cargo.toml | Updates dependency key from uplc-turbo to amaru-uplc-turbo. |
| crates/amaru-ledger/Cargo.toml | Updates dependency key from uplc-turbo to amaru-uplc-turbo. |
| Cargo.toml | Replaces the git dependency with a versioned amaru-uplc-turbo workspace dependency. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| amaru-tracing-json = { path = "crates/amaru-tracing-json", version = "0.1.1" } | ||
| pure-stage = { path = "crates/pure-stage", version = "0.1.1" } | ||
| uplc-turbo = { git = "https://github.com/pragma-org/uplc" } | ||
| amaru-uplc-turbo = "0.1.0" |
There was a problem hiding this comment.
Renaming the dependency key from uplc-turbo to amaru-uplc-turbo changes the crate identifier exposed to Rust code (from uplc_turbo to amaru_uplc_turbo). If the code still imports uplc_turbo, builds will fail. If the intent is to keep the existing crate name in code, define the workspace dependency under the old key and rename the package instead (e.g., keep uplc-turbo as the dependency name, with package = \"amaru-uplc-turbo\").
| amaru-uplc-turbo = "0.1.0" | |
| uplc-turbo = { package = "amaru-uplc-turbo", version = "0.1.0" } |
| [dependencies] | ||
| # External dependencies | ||
| uplc-turbo.workspace = true | ||
| amaru-uplc-turbo.workspace = true |
There was a problem hiding this comment.
This dependency key change forces downstream code in this crate to reference the crate as amaru_uplc_turbo instead of uplc_turbo. If this PR is intended to be a drop-in replacement without touching Rust source imports, consider keeping the dependency name uplc-turbo here (and in the workspace) and using Cargo's package = \"amaru-uplc-turbo\" rename mechanism.
| amaru-uplc-turbo.workspace = true | |
| uplc-turbo = { workspace = true, package = "amaru-uplc-turbo" } |
| amaru-plutus.workspace = true | ||
| amaru-progress-bar.workspace = true | ||
| uplc-turbo.workspace = true | ||
| amaru-uplc-turbo.workspace = true |
There was a problem hiding this comment.
Same issue as in amaru-plutus: the dependency key determines the crate name used in Rust code. If existing imports expect uplc_turbo, this will break compilation unless the Rust source is updated accordingly. Prefer using a package = \"amaru-uplc-turbo\" rename while keeping the dependency name stable if you want compatibility.
| amaru-uplc-turbo.workspace = true | |
| uplc_turbo = { workspace = true, package = "amaru-uplc-turbo" } |
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
Signed-off-by: jeluard <jeluard@users.noreply.github.com>
886d1b7 to
021fec5
Compare
Signed-off-by: jeluard <jeluard@users.noreply.github.com>
Summary by CodeRabbit