Skip to content

fix: package build.rs#717

Merged
jeluard merged 1 commit intomainfrom
jeluard/missing-build
Mar 6, 2026
Merged

fix: package build.rs#717
jeluard merged 1 commit intomainfrom
jeluard/missing-build

Conversation

@jeluard
Copy link
Copy Markdown
Contributor

@jeluard jeluard commented Mar 6, 2026

Summary by CodeRabbit

  • Chores
    • Updated build script configuration and expanded manifest declarations to enhance the build process organization

Signed-off-by: jeluard <jeluard@users.noreply.github.com>
Copilot AI review requested due to automatic review settings March 6, 2026 06:45
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 6, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 15a1fe01-a834-4e52-b36b-d41918d7f092

📥 Commits

Reviewing files that changed from the base of the PR and between 24cf48b and 718024a.

📒 Files selected for processing (2)
  • crates/amaru-ledger/Cargo.toml
  • crates/amaru/Cargo.toml

Walkthrough

G'day! These changes are pretty straightforward—we're enabling Cargo build scripts across two crates. The amaru-ledger crate now declares build = "build.rs" to run its build script, while amaru's manifest gets updated to include build.rs in the package contents. No functional logic changes, just plumbing the infrastructure together, ya know?

Changes

Cohort / File(s) Summary
Build Script Infrastructure
crates/amaru-ledger/Cargo.toml, crates/amaru/Cargo.toml
Declares build script entry point in amaru-ledger and updates amaru's include array to package build.rs file, enabling build-time script execution.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • KtorZ

Poem

🔨 Scripts in the build, now we're cooking with gas,
Build.rs declared, manifest lookin' class,
No more messy nights—just smooth as a film scene,
The cleanest build pipeline you've ever seen! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely summarizes the main change: adding build.rs file declarations to package manifests across multiple crates.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch jeluard/missing-build

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes crate packaging/build-script configuration so published artifacts include and run the intended build.rs scripts.

Changes:

  • Update amaru crate packaging whitelist to include build.rs.
  • Explicitly declare build = "build.rs" for amaru-ledger.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
crates/amaru/Cargo.toml Ensures the build script is included in the crate’s packaged file set.
crates/amaru-ledger/Cargo.toml Declares the crate build script explicitly via the build field.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
see 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jeluard jeluard merged commit af93e3f into main Mar 6, 2026
31 checks passed
@jeluard jeluard deleted the jeluard/missing-build branch March 6, 2026 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants