Skip to content

fix: preserve method and class name decorated with OtelXxxCounter#542

Merged
pragmaticivan merged 2 commits intopragmaticivan:mainfrom
Papooch:fix/preserve-names-of-counted-things
May 15, 2025
Merged

fix: preserve method and class name decorated with OtelXxxCounter#542
pragmaticivan merged 2 commits intopragmaticivan:mainfrom
Papooch:fix/preserve-names-of-counted-things

Conversation

@Papooch
Copy link
Contributor

@Papooch Papooch commented May 15, 2025

Which problem is this PR solving?

The same problem as #538

Short description of the changes

  • Use Proxy to preserve decorated method name.
  • Explicitly define name property on decorated class.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • added tests to common.spec.ts

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated (not needed)

Copy link
Owner

@pragmaticivan pragmaticivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

@pragmaticivan pragmaticivan merged commit 4019981 into pragmaticivan:main May 15, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants