Skip to content

Comments

Design for IRC channel reader, parser and iterator#344

Open
tejalwakchoure wants to merge 6 commits intoprasadtalasila:devfrom
tejalwakchoure:reader
Open

Design for IRC channel reader, parser and iterator#344
tejalwakchoure wants to merge 6 commits intoprasadtalasila:devfrom
tejalwakchoure:reader

Conversation

@tejalwakchoure
Copy link

What? Why?

Fix #341.

Changes proposed in this pull request:

  • Update lib/in_out/reader.py
  • Update test_reader.py

Notify reviewers

@prasadtalasila

@coveralls
Copy link

coveralls commented Nov 30, 2018

Coverage Status

Coverage decreased (-21.8%) to 33.631% when pulling 10cc5d4 on tejalwakchoure:reader into eec9e0a on prasadtalasila:dev.

@codecov
Copy link

codecov bot commented Nov 30, 2018

Codecov Report

Merging #344 into dev will decrease coverage by 0.31%.
The diff coverage is 94.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #344      +/-   ##
==========================================
- Coverage   97.55%   97.24%   -0.32%     
==========================================
  Files          22       22              
  Lines        2376     2465      +89     
==========================================
+ Hits         2318     2397      +79     
- Misses         58       68      +10
Flag Coverage Δ
#functional 33.63% <70.24%> (-21.76%) ⬇️
#integration 58.29% <0%> (-2.19%) ⬇️
#unit 95.13% <94.21%> (-0.12%) ⬇️
Impacted Files Coverage Δ
lib/in_out/reader.py 94.69% <94.21%> (-5.31%) ⬇️
lib/analysis/network.py 99.11% <0%> (-0.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eec9e0a...10cc5d4. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants