Skip to content

Revise confusing 'valign' error message for text boxes#1377

Merged
pointlessone merged 3 commits intoprawnpdf:masterfrom
lasaldan:patch-1
May 2, 2025
Merged

Revise confusing 'valign' error message for text boxes#1377
pointlessone merged 3 commits intoprawnpdf:masterfrom
lasaldan:patch-1

Conversation

@lasaldan
Copy link
Copy Markdown
Contributor

Problem:
Using an unsupported symbol for the value of 'valign' on a text box throws a misleading error message.

Solution:
This adjusts the error message to match the actual values supported by the code.

Using an unsupported symbol for the value of 'valign' on a text box throws a misleading error message. This adjusts the error message to match the actual values supported by the code.
Copy link
Copy Markdown
Member

@pointlessone pointlessone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution.

@pointlessone
Copy link
Copy Markdown
Member

Would you please fix the specs?

@lasaldan
Copy link
Copy Markdown
Contributor Author

lasaldan commented May 2, 2025

@pointlessone Sorry for not updating the specs the first time around. They are passing now, other than the PrawnByExampleManual hash tests. Looks like those broke around the bump of prawn-dev to 0.5 back in January.

I did try to investigate those failing tests, but couldn't determine definitively what causes the hash mismatch. I pulled the prawn-manual_builder gem so I could build the PDF manual locally, but the hash of the local PDF was indeed different than what was expected in the test. Not sure if the test needs the hash updated to the new PDF hash, or if there is something in the generated PDF that is incorrect causing the hashes to be different.

Either way, that's a different issue and PR. Let me know if this one needs anything else. Thanks so so much for Prawn.

@pointlessone
Copy link
Copy Markdown
Member

Sorry, I meant only these specs. The hash one is tracked elsewhere and is a bit more involved. I'll get to it eventually.

Thank you.

@pointlessone pointlessone merged commit 1442068 into prawnpdf:master May 2, 2025
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants