Revise confusing 'valign' error message for text boxes#1377
Revise confusing 'valign' error message for text boxes#1377pointlessone merged 3 commits intoprawnpdf:masterfrom
Conversation
Using an unsupported symbol for the value of 'valign' on a text box throws a misleading error message. This adjusts the error message to match the actual values supported by the code.
pointlessone
left a comment
There was a problem hiding this comment.
Thank you for your contribution.
|
Would you please fix the specs? |
|
@pointlessone Sorry for not updating the specs the first time around. They are passing now, other than the PrawnByExampleManual hash tests. Looks like those broke around the bump of prawn-dev to 0.5 back in January. I did try to investigate those failing tests, but couldn't determine definitively what causes the hash mismatch. I pulled the prawn-manual_builder gem so I could build the PDF manual locally, but the hash of the local PDF was indeed different than what was expected in the test. Not sure if the test needs the hash updated to the new PDF hash, or if there is something in the generated PDF that is incorrect causing the hashes to be different. Either way, that's a different issue and PR. Let me know if this one needs anything else. Thanks so so much for Prawn. |
|
Sorry, I meant only these specs. The hash one is tracked elsewhere and is a bit more involved. I'll get to it eventually. Thank you. |
Problem:
Using an unsupported symbol for the value of 'valign' on a text box throws a misleading error message.
Solution:
This adjusts the error message to match the actual values supported by the code.