UI: Use DragFloat3 for Camera Offset controls#413
Open
chrisraff wants to merge 3 commits intopraydog:masterfrom
Open
UI: Use DragFloat3 for Camera Offset controls#413chrisraff wants to merge 3 commits intopraydog:masterfrom
chrisraff wants to merge 3 commits intopraydog:masterfrom
Conversation
…loat3 Co-authored-by: chrisraff <22504698+chrisraff@users.noreply.github.com>
Contributor
|
change looks fine to me. Is it worth looking for other instances in the UI where the sensitivity & resolution of the sliders could be improved? No idea why the PR build fails |
Author
|
I just ran through the UI, the only other slider I found where this seems like an issue to me would be "input > controller pitch offset" since its range is +- 90 and very precise changes could be valuable. However, it's already quite a large slider. Lmk if I should do that change or you want anything else before accepting the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Camera Offset sliders under Camera Freeze use
SliderFloat3with a +- 4000 range,which makes dialing in precise position values impractical - the slider moves too
coarsely to land on a specific value.
This replaces them with
DragFloat3, which:A tooltip is added to the control to surface these shortcuts for users who may not
be familiar with ImGui drag inputs.
Initial implementation by GitHub Copilot.