Timescale constants

Author: prdoyle

bosk-mongo/src/test/java/works/bosk/drivers/mongo/internal/MongoDriverRecoveryTest.java

@@ -29,6 +29,7 @@
 import static ch.qos.logback.classic.Level.ERROR;
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertThrows;
+import static works.bosk.drivers.mongo.internal.TestParameters.SHORT_TIMESCALE;
 import static works.bosk.testing.BoskTestUtils.boskName;
 import static works.bosk.ListingEntry.LISTING_ENTRY;
 import static works.bosk.drivers.mongo.internal.MainDriver.COLLECTION_NAME;
@@ -62,7 +63,7 @@ static Stream<TestParameters.ParameterSet> parameters() {
 			),
 			Stream.of(TestParameters.EventTiming.NORMAL)
 		).map(b -> b.applyDriverSettings(s -> s
-			.timescaleMS(100) // Note that some tests can take as long as 25x this
+			.timescaleMS(SHORT_TIMESCALE) // Note that some tests can take as long as 25x this
 		));
 	}
 

bosk-mongo/src/test/java/works/bosk/drivers/mongo/internal/MongoDriverSpecialTest.java

@@ -56,6 +56,7 @@
 import static org.junit.jupiter.api.Assertions.assertNull;
 import static org.junit.jupiter.api.Assertions.assertThrows;
 import static org.junit.jupiter.api.Assertions.assertTrue;
+import static works.bosk.drivers.mongo.internal.TestParameters.SHORT_TIMESCALE;
 import static works.bosk.testing.BoskTestUtils.boskName;
 import static works.bosk.ListingEntry.LISTING_ENTRY;
 
@@ -78,7 +79,7 @@ static Stream<TestParameters.ParameterSet> parameters() {
 			),
 			Stream.of(TestParameters.EventTiming.NORMAL)
 		).map(b -> b.applyDriverSettings(s -> s
-			.timescaleMS(100) // Note that some tests can take as long as 25x this
+			.timescaleMS(SHORT_TIMESCALE) // Note that some tests can take as long as 25x this
 		));
 	}
 

bosk-mongo/src/test/java/works/bosk/drivers/mongo/internal/TestParameters.java

@@ -12,6 +12,18 @@
 public class TestParameters {
 	private static final AtomicInteger dbCounter = new AtomicInteger(0);
 
+	/**
+	 * For tests that are expecting timeouts. A short value makes the tests run faster.
+	 * Too short, and the tests might not be testing the right thing.
+	 * This should be much larger than the expected latency of MongoDB and the network.
+	 */
+	public static final int SHORT_TIMESCALE = 100;
+
+	/**
+	 * For tests that are not expecting timeouts. A nice long value makes spurious test failures unlikely.
+	 */
+	public static final int LONG_TIMESCALE = 90_000;
+
 	@Value
 	public static class ParameterSet {
 		String name;
@@ -26,7 +38,7 @@ public static ParameterSet from(MongoDriverSettings.DatabaseFormat format, Event
 				timing + "," + format,
 				MongoDriverSettings.builder()
 					.preferredDatabaseFormat(format)
-					.timescaleMS(90_000) // Tests that actually exercise timeouts should use a much shorter value
+					.timescaleMS(LONG_TIMESCALE)
 					.testing(MongoDriverSettings.Testing.builder()
 						.eventDelayMS(timing.eventDelayMS)
 						.build())