Skip to content

Conversation

@njzjz
Copy link

@njzjz njzjz commented Oct 2, 2024

Clang-format 19 breaks ipynb files. xref: llvm/llvm-project#110727 I can't find a way to exclude a format in pre-commit-mirror, so I remove the JSON format directly to ensure the hook doesn't break any files with the default configuration.

Clang-format 19 breaks ipynb files. xref: llvm/llvm-project#110727 I can't find a way to exclude a format in pre-commit-mirror, so I remove the JSON format directly to ensure the hook doesn't break any files with the default configuration.
@asottile
Copy link
Member

asottile commented Oct 2, 2024

seems best for now to just override this in your own config (probably with exclude: ?) assuming this will get fixed upstream

@njzjz
Copy link
Author

njzjz commented Dec 22, 2024

The upstream has closed llvm/llvm-project#110727 without a fix.

@Timple
Copy link

Timple commented Aug 12, 2025

llvm/llvm-project#135137 was merged and has landed in version LLVM 21.1.0-rc1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants