Skip to content

4.5.1 #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 12, 2025
Merged

4.5.1 #109

merged 1 commit into from
Sep 12, 2025

Conversation

rschristian
Copy link
Member

Mainly for #107 as I had borked the type signature

JoviDeCroock
JoviDeCroock approved these changes Sep 12, 2025
View reviewed changes
Copy link
Member

@JoviDeCroock JoviDeCroock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes me think it might be worth adding this to the ecosystem ci?

@rschristian
Copy link
Member Author

rschristian commented Sep 12, 2025 •
edited
Loading

Certainly can do, though this would've passed as we aren't doing type checking in our tests here.

Will add a few tests later

@rschristian rschristian merged commit 64b973c into master Sep 12, 2025
1 check passed
@rschristian rschristian deleted the 4.5.1 branch September 12, 2025 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoviDeCroock JoviDeCroock JoviDeCroock approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rschristian @JoviDeCroock