chore: Bump deps and ci action, add editorconfig #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rschristian
commented
Sep 2, 2025
Comment on lines
-22
to
+21
| "version": "latest" | ||
| "version": "16.8" |
There was a problem hiding this comment.
ESLint throws a bunch of warnings otherwise
| "build": "microbundle -f cjs,es,umd", | ||
| "lint": "eslint src/*.{js,jsx}", | ||
| "test": "wtr src/*.test.{js,jsx}", | ||
| "test:browsers": "wtr src/*.test.{js,jsx} --playwright --browsers chromium firefox webkit", |
There was a problem hiding this comment.
Playwright is slow to install and rather unwieldy, I don't think it's really needed here anyhow? Our tests aren't that interesting or on the bleeding edge. running in just chromium should be more than fine.
Edit: And, of course, these don't run at the moment anyhow. I gave it a shot but it fell over and I'm not sure it's worth fixing (or at least I won't bother).
|
I'll have to update the CI config once approved; giving the CI job a name (which, IMO, makes it look nicer and allows for better expansion later) breaks the check. |
rschristian
force-pushed
the
chore/bump-deps-and-ci-actions
branch
from
4316b0b to
847b99e
Compare
JoviDeCroock
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.