Draft
Conversation
c624b01 to
b6f13d1
Compare
1f2b71d to
3b0bd37
Compare
781b472 to
eafea6e
Compare
5802816 to
84811ca
Compare
9d31f42 to
379f6e6
Compare
394bd76 to
bb7ce7f
Compare
02d84b4 to
1ab8157
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ideas for v3, as I'll forget them otherwise. Certainly not set in stone if anyone has concerns or other ideas. Feedback welcome and appreciated!
./prerender/prerender, and only offer the prerender script through it, to avoid some headaches with the RTS optional peer dep (see fix: RTS peer dep w/ Vite #13)hydrate()exportsrender()andhydrate()internally and only functions correctly if used w/ iso'sprerender().useRouteanduseLocationuseLocationanduseRoutehave some overlapping properties and can end up firing between renders, leading to tearing. Consolidating down is ideal IMO.useRoute().params->pathParams&useRoute().query->searchParamsvue-routerin our naming but personally I dislike the ambiguity (paramscan easily refer to both path parameters & query parameters) and a few people I've spoken to seem to agree. These seem to be better & immediately understandable to anyone, regardless of which routers they've used in the past.To Do:
useLocation().urlanduseLocation().pathwill just about always matchTo Think About: