Skip to content

fix: Ensure cellPadding, cellSpacing, and useMap are lower-cased #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 11, 2024
Merged

fix: Ensure cellPadding, cellSpacing, and useMap are lower-cased #352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5bf7d31
fix: Ensure `cellPadding`, `cellSpacing`, and `useMap` are lower-cased
rschristian May 11, 2024
62c16b7
docs: Add changeset
rschristian May 11, 2024
42800ff
Merge branch 'main' into fix/cell-usemap
rschristian May 11, 2024
77bd640
Update src/lib/util.js
rschristian May 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/gorgeous-eyes-cheer.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'preact-render-to-string': patch
---

Ensure `cellPadding`, `cellSpacing`, and `useMap` are serialized to lower case
2 changes: 1 addition & 1 deletion src/lib/util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
export const VOID_ELEMENTS = /^(?:area|base|br|col|embed|hr|img|input|link|meta|param|source|track|wbr)$/;
export const UNSAFE_NAME = /[\s\n\\/='"\0<>]/;
export const NAMESPACE_REPLACE_REGEX = /^(xlink|xmlns|xml)([A-Z])/;
export const HTML_LOWER_CASE = /^accessK|^auto[A-Z]|^ch|^col|cont|cross|dateT|encT|form[A-Z]|frame|hrefL|inputM|maxL|minL|noV|playsI|popoverT|readO|rowS|spellC|src[A-Z]|tabI|item[A-Z]/;
export const HTML_LOWER_CASE = /^accessK|^auto[A-Z]|^cell|^ch|^col|cont|cross|dateT|encT|form[A-Z]|frame|hrefL|inputM|maxL|minL|noV|playsI|popoverT|readO|rowS|spellC|src[A-Z]|tabI|useM|item[A-Z]/;
export const SVG_CAMEL_CASE = /^ac|^ali|arabic|basel|cap|clipPath$|clipRule$|color|dominant|enable|fill|flood|font|glyph[^R]|horiz|image|letter|lighting|marker[^WUH]|overline|panose|pointe|paint|rendering|shape|stop|strikethrough|stroke|text[^L]|transform|underline|unicode|units|^v[^i]|^w|^xH/;

// DOM properties that should NOT have "px" added when numeric
Expand Down
6 changes: 3 additions & 3 deletions test/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,8 +297,8 @@ export const htmlAttributes = {
autoFocus: 'autofocus',
autoPlay: 'autoplay',
capture: 'capture',
cellPadding: 'cellPadding',
cellSpacing: 'cellSpacing',
cellPadding: 'cellpadding',
cellSpacing: 'cellspacing',
charSet: 'charset',
challenge: 'challenge',
checked: 'checked',
Expand Down Expand Up @@ -414,7 +414,7 @@ export const htmlAttributes = {
target: 'target',
title: 'title',
type: 'type',
useMap: 'useMap',
useMap: 'usemap',
value: 'value',
volume: 'volume',
width: 'width',
Expand Down