Skip to content

Conversation

rschristian
Copy link
Member

Locally I was seeing some bizarre numbers for the "current" bench, about 50% faster. Took me a few minutes to realize I had an old build sitting around 😅

I think this setup should work better? As the bench uses the built files from /dist, you'll always want to run a build whilst playing with the benchmarks. The tests themselves use the source files though, so they don't inherently need it.

Copy link

changeset-bot bot commented Sep 14, 2024

⚠️ No Changeset found

Latest commit: bc80e6d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@rschristian rschristian merged commit d20ad14 into main Sep 14, 2024
1 check passed
@rschristian rschristian deleted the chore/run-build-prebench branch September 14, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants