Skip to content

Fix computed to use the hook form #764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 9, 2025
Merged

Fix computed to use the hook form #764

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b5d82ac
Fix computed to use the hook form
JoviDeCroock Oct 7, 2025
11fc83b
Merge branch 'main' into fix-computed
JoviDeCroock Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions extension/src/components/Graph.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { useRef } from "preact/hooks";
import { Signal, computed } from "@preact/signals";
import { Signal, computed, useComputed, useSignal } from "@preact/signals";
import {
Divider,
GraphData,
Expand All @@ -15,7 +15,7 @@ export function GraphVisualization() {
const svgRef = useRef<SVGSVGElement>(null);

// Build graph data from updates signal using a computed
const graphData = computed<GraphData>(() => {
const graphData = useComputed<GraphData>(() => {
const rawUpdates = updates.value;
if (!rawUpdates || rawUpdates.length === 0)
return { nodes: [], links: [], components: [] };
Expand Down