Skip to content

fix: Support custom output names #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rschristian merged 2 commits into from
Mar 15, 2025
Merged

fix: Support custom output names #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce7dffa
fix: Support custom output names/paths
rschristian Mar 15, 2025
9645bae
test: Add cases confirming behavior
rschristian Mar 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/plugins/prerender-plugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,8 +303,10 @@ export function prerenderPlugin({ prerenderScript, renderTarget, additionalPrere
for (const output of Object.keys(bundle)) {
if (!output.endsWith('.js') || bundle[output].type !== 'chunk') continue;

const assetPath = path.join(tmpDir, output);
await fs.mkdir(path.dirname(assetPath), { recursive: true });
await fs.writeFile(
path.join(tmpDir, path.basename(output)),
assetPath,
/** @type {OutputChunk} */ (bundle[output]).code,
);

Expand Down Expand Up @@ -372,7 +374,7 @@ export function prerenderPlugin({ prerenderScript, renderTarget, additionalPrere
let prerender;
try {
const m = await import(
`file://${path.join(tmpDir, path.basename(prerenderEntry.fileName))}`
`file://${path.join(tmpDir, prerenderEntry.fileName)}`
);
prerender = m.prerender;
} catch (e) {
Expand Down
9 changes: 9 additions & 0 deletions tests/fixtures/named-chunks/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8" />
</head>
<body>
<script prerender type="module" src="/src/index.js"></script>
</body>
</html>
5 changes: 5 additions & 0 deletions tests/fixtures/named-chunks/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
import('./split-chunk.js');

export async function prerender() {
return `<h1>Simple Test Result</h1>`;
}
3 changes: 3 additions & 0 deletions tests/fixtures/named-chunks/src/split-chunk.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
globalThis.splitChunk = function splitChunk() {
console.log('splitChunk');
}
6 changes: 6 additions & 0 deletions tests/fixtures/named-chunks/vite.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
import { defineConfig } from 'vite';
import { vitePrerenderPlugin } from 'vite-prerender-plugin';

export default defineConfig({
plugins: [vitePrerenderPlugin()],
});
29 changes: 29 additions & 0 deletions tests/index.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,4 +73,33 @@ test('Should support comment nodes in returned HTML', async () => {
assert.match(prerenderedHtml, '<!-- With Input HTML Comment -->');
});

test('Should support custom output filenames', async () => {
await loadFixture('named-chunks', env);
await writeConfig(env.tmp.path, `
import { defineConfig } from 'vite';
import { vitePrerenderPlugin } from 'vite-prerender-plugin';

export default defineConfig({
build: {
rollupOptions: {
output: {
chunkFileNames: 'chunks/[name].[hash].js',
}
}
},
plugins: [vitePrerenderPlugin()],
});
`);
await viteBuild(env.tmp.path);

let message = '';
try {
await viteBuild(env.tmp.path);
} catch (error) {
message = error.message;
}

assert.match(message, '');
});

test.run();