Prebid 11.0

.github/workflows/linter.yml

@@ -16,7 +16,7 @@ jobs:
       - name: Set up Node.js
         uses: actions/setup-node@v6
         with:
-          node-version: '20'
+          node-version: "20"
 
       - name: Checkout code
         uses: actions/checkout@v6
@@ -35,6 +35,9 @@ jobs:
       - name: Get the diff
         run: git diff --name-only origin/${{ github.event.pull_request.base.ref }}...refs/remotes/pull/${{ github.event.pull_request.number }}/merge | grep '^\(modules\|src\|libraries\|creative\)/.*\.js$' > __changed_files.txt || true
 
+      - name: Get newly added JS files in TS migration paths
+        run: git diff --name-only --diff-filter=A origin/${{ github.event.pull_request.base.ref }}...refs/remotes/pull/${{ github.event.pull_request.number }}/merge | grep '^\(modules\|src\|libraries\)/.*\.js$' > __new_js_files.txt || true
+
       - name: Run linter on base branch
         run: npx eslint --no-inline-config --format json $(cat __changed_files.txt | xargs stat --printf '%n\n' 2> /dev/null) > __base.json || true
 
@@ -56,7 +59,7 @@ jobs:
             const fs = require('fs');
             const path = require('path');
             const process = require('process');
-            
+
             function parse(fn) {
               return JSON.parse(fs.readFileSync(fn)).reduce((memo, data) => {
                 const file = path.relative(process.cwd(), data.filePath);
@@ -67,7 +70,7 @@ jobs:
                 return memo;
               }, {})
             }
-            
+
             function mkDiff(old, new_) {
               const files = Object.fromEntries(
                 Object.entries(new_)
@@ -83,12 +86,23 @@ jobs:
                 return memo;
               }, {errors: 0, warnings: 0, files})
             }
-            
-            function mkComment({errors, warnings, files}) {
+
+            function mkComment({errors, warnings, files}, newJsFiles) {
               function pl(noun, number) {
                 return noun + (number === 1 ? '' : 's')
               }
-              if (errors === 0 && warnings === 0) return;
+              const comments = [];
+
+              if (newJsFiles.length > 0) {
+                let jsComment = 'Whoa there partner! This project is migrating to typescript. Consider changing the new JS files to TS, with well-defined types for what interacts with the prebid public API (for example: bid params and configuration). Thanks!\n\n';
+                newJsFiles.forEach((file) => {
+                  jsComment += ` * \`${file}\`\n`;
+                });
+                comments.push(jsComment);
+              }
+
+              if (errors === 0 && warnings === 0) return comments.length > 0 ? comments.join('\n') : undefined;
+
               const summary = [];
               if (errors) summary.push(`**${errors}** linter ${pl('error', errors)}`)
               if (warnings) summary.push(`**${warnings}** linter ${pl('warning', warnings)}`)
@@ -99,12 +113,18 @@ jobs:
                 if (warnings) summary.push(`+${warnings} ${pl('warning', warnings)}`)
                 cm += ` * \`${file}\` (${summary.join(', ')})\n`
               })
-              return cm;
+              comments.push(cm);
+              return comments.join('\n');
+            }
+
+            function readLines(fn) {
+              if (!fs.existsSync(fn)) return [];
+              return fs.readFileSync(fn, 'utf8').split('\n').map(line => line.trim()).filter(Boolean);
             }
-            
+
             const [base, pr] = ['__base.json', '__pr.json'].map(parse);
-            const comment = mkComment(mkDiff(base, pr));
-            
+            const comment = mkComment(mkDiff(base, pr), readLines('__new_js_files.txt'));
+
             if (comment) {
               fs.writeFileSync("${{ runner.temp }}/comment.json", JSON.stringify({
                 issue_number: context.issue.number,

AGENTS.md

@@ -21,6 +21,7 @@ This file contains instructions for the Codex agent and its friends when working
 
 ## General guidance
 - Node.js `>=20` is required; dependencies are managed with `npm`.
+- Whenever possible, new modules should provide Typescript types for their public interface.
 - Added or modified code must have at least 80% unit test coverage.
 - Link any required documentation PRs in the PR description.
 - Avoid modifying files in `node_modules` or generated build artifacts under `build`.

CONTRIBUTING.md

@@ -6,6 +6,9 @@ master branch.
 Pull requests must have 80% code coverage before being considered for merge.
 Additional details about the process can be found [here](./PR_REVIEW.md).
 
+Whenever possible, new modules should provide Typescript types for their public interface.
+Examples of public interface are bid parameters and configuration (including configuration for analytics, userId, or real time data modules). 
+
 There are more details available if you'd like to contribute a [bid adapter](https://docs.prebid.org/dev-docs/bidder-adaptor.html) or [analytics adapter](https://docs.prebid.org/dev-docs/integrate-with-the-prebid-analytics-api.html).
 
 ## Issues

PR_REVIEW.md

@@ -19,6 +19,7 @@ General gulp commands include separate commands for serving the codebase on a bu
 
 ### General PR review Process
 
+- Whenever possible, new modules should provide Typescript types for their public interface. Examples of public interface are bid parameters and configuration (including configuration for analytics, userId, or real time data modules).
 - All required global and bidder-adapter rules defined in the [Module Rules](https://docs.prebid.org/dev-docs/module-rules.html) must be followed. Please review these rules often - we depend on reviewers to enforce them.
 - Checkout the branch (these instructions are available on the GitHub PR page as well).
 - Verify PR is a single change type. Example, refactor OR bugfix. If more than 1 type, ask submitter to break out requests.

eslint.config.js

@@ -202,6 +202,21 @@ module.exports = [
             object: 'navigator',
             message: 'use ajax.js instead'
           },
+          {
+            property: 'doNotTrack',
+            object: 'navigator',
+            message: 'DNT was deprecated by W3C; Prebid no longer supports DNT signals'
+          },
+          {
+            property: 'msDoNotTrack',
+            object: 'navigator',
+            message: 'DNT was deprecated by W3C; Prebid no longer supports DNT signals'
+          },
+          {
+            property: 'doNotTrack',
+            object: 'window',
+            message: 'DNT was deprecated by W3C; Prebid no longer supports DNT signals'
+          },
           ...['outerText', 'innerText'].map(property => ({
             property,
             message: 'use .textContent instead'

integrationExamples/gpt/raveltechRtdProvider_example.html

@@ -256,9 +256,6 @@
                 "expires": 28
               }
             },
-            {
-              "name": "quantcastId"
-            },
             {
               "name": "criteo"
             },

integrationExamples/gpt/userId_example.html

@@ -234,9 +234,6 @@
                 "expires": 28
               }
             },
-            {
-              "name": "quantcastId"
-            },
             {
               "name": "criteo"
             },